- 05 Oct, 2015 1 commit
-
-
tandrii@chromium.org authored
BUG=537417 R=sergiyb@chromium.org,phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/1373363006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297012 0039d316-1c4b-4281-b951-d872f2087c98
-
- 02 Oct, 2015 3 commits
-
-
tandrii@chromium.org authored
R=iannucci@chromium.org BUG= Review URL: https://codereview.chromium.org/1375343005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296990 0039d316-1c4b-4281-b951-d872f2087c98
-
tandrii@chromium.org authored
R=sergiyb@chromium.org,phajdan.jr@chromium.org BUG=537417 Review URL: https://codereview.chromium.org/1385653002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296986 0039d316-1c4b-4281-b951-d872f2087c98
-
tandrii@chromium.org authored
This would allow bot_update to differentiate between patch download and aplication failures. R=phajdan.jr@chromium.org,sergiyb@chromium.org BUG=537417 Review URL: https://codereview.chromium.org/1380093003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296983 0039d316-1c4b-4281-b951-d872f2087c98
-
- 15 Jul, 2015 1 commit
-
-
rmistry@google.com authored
Revert of Comment out applying patchset dependencies in apply_issue.py (patchset #2 id:20001 of https://codereview.chromium.org/1194063003/) Reason for revert: https://chromereviews.googleplex.com/221697013/ has landed. Re-enable applying patchset dependencies in apply_issue.py Original issue's description: > Comment out applying patchset dependencies in apply_issue.py > > Context is in the internal chrome-infra thread here: > https://groups.google.com/a/google.com/d/msg/chrome-infra/dNQGjNoP-Dg/XDymPAwOCXkJ > > NOPRESUBMIT=true > > BUG=chromium:480453 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295800 TBR=phajdan.jr@chromium.org BUG=chromium:480453 Review URL: https://codereview.chromium.org/1237703004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296016 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Jun, 2015 2 commits
-
-
rmistry@google.com authored
Context is in the internal chrome-infra thread here: https://groups.google.com/a/google.com/d/msg/chrome-infra/dNQGjNoP-Dg/XDymPAwOCXkJ NOPRESUBMIT=true BUG=chromium:480453 Review URL: https://codereview.chromium.org/1194063003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295800 0039d316-1c4b-4281-b951-d872f2087c98
-
rmistry@google.com authored
Here is an explanation of the changes in each module: * git_cl.py - IF a local branch is being tracked AND a CL has been uploaded there THEN use the CL's issue number and latest patchset as a dependency. * upload.py - Uploads the patchset dependency, if it exists, to Rietveld (Rietveld will be able to parse this when https://codereview.chromium.org/1155513002/ lands). * rietveld.py - Adds utility methods to get patchset dependencies from the new Rietveld endpoint (the endpoint will exist when https://codereview.chromium.org/1155513002/ lands). * apply_issue.py - If CL3 depends on CL2 which in turn depends on CL1 then apply_issue will gather a list of all issues and patchsets to apply (Eg: [CL1:PS1, CL2:PS1, CL3:PS2]). apply_issue will then loop over the list applying each dependency. Note: The apply_issue.py diff looks much worse than it is. Please see my comment in https://codereview.chromium.org/1149653002/diff/260001/apply_issue.py#oldcode169 Tested end-to-end using a test Git repository (https://skia.googlesource.com/skiabot-test/) and the following CLs created in my test Rietveld instance: * https://skia-codereview-staging.appspot.com/931002 ('Branch1 CL') * https://skia-codereview-staging.appspot.com/5001001 ('Branch2 CL') * https://skia-codereview-staging.appspot.com/9881001 ('Branch3 CL') * https://skia-codereview-staging.appspot.com/3951001 ('Branch3.1 CL') Opt into the new UI and observe the new 'Depends on Patchset' and 'Dependent Patchsets' sections in the above CLs. Design doc is here: https://docs.google.com/document/d/1KZGFKZpOPvco81sYVRCzwlnjGctup71RAzY0MSb0ntc/edit#heading=h.6r6lt4tsvssw BUG=502255 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295778 Review URL: https://codereview.chromium.org/1149653002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295799 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 Jun, 2015 2 commits
-
-
rmistry@google.com authored
Revert of [depot_tools] Find, upload and apply patchset dependencies (patchset #17 id:360001 of https://codereview.chromium.org/1149653002/) Reason for revert: Ran into a crash during the bot_update step here: https://uberchromegw.corp.google.com/i/internal.infra.try/builders/infra-internal-presubmit/builds/62 Original issue's description: > Find, upload and apply patchset dependencies. > > Here is an explanation of the changes in each module: > > * git_cl.py - > IF a local branch is being tracked AND a CL has been uploaded there THEN use the CL's issue number and latest patchset as a dependency. > > * upload.py - > Uploads the patchset dependency, if it exists, to Rietveld (Rietveld will be able to parse this when https://codereview.chromium.org/1155513002/ lands). > > * rietveld.py - > Adds utility methods to get patchset dependencies from the new Rietveld endpoint (the endpoint will exist when https://codereview.chromium.org/1155513002/ lands). > > * apply_issue.py - > If CL3 depends on CL2 which in turn depends on CL1 then apply_issue will gather a list of all issues and patchsets to apply (Eg: [CL1:PS1, CL2:PS1, CL3:PS2]). > apply_issue will then loop over the list applying each dependency. > Note: The apply_issue.py diff looks much worse than it is. Please see my comment in > https://codereview.chromium.org/1149653002/diff/260001/apply_issue.py#oldcode169 > > > Tested end-to-end using a test Git repository (https://skia.googlesource.com/skiabot-test/) and the following CLs created in my test Rietveld instance: > * https://skia-codereview-staging.appspot.com/931002 ('Branch1 CL') > * https://skia-codereview-staging.appspot.com/5001001 ('Branch2 CL') > * https://skia-codereview-staging.appspot.com/9881001 ('Branch3 CL') > * https://skia-codereview-staging.appspot.com/3951001 ('Branch3.1 CL') > Opt into the new UI and observe the new 'Depends on Patchset' and 'Dependent Patchsets' sections in the above CLs. > > > Design doc is here: https://docs.google.com/document/d/1KZGFKZpOPvco81sYVRCzwlnjGctup71RAzY0MSb0ntc/edit#heading=h.6r6lt4tsvssw > > BUG=502255 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295778 TBR=agable@chromium.org,jrobbins@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=502255 Review URL: https://codereview.chromium.org/1200773003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295782 0039d316-1c4b-4281-b951-d872f2087c98
-
rmistry@google.com authored
Here is an explanation of the changes in each module: * git_cl.py - IF a local branch is being tracked AND a CL has been uploaded there THEN use the CL's issue number and latest patchset as a dependency. * upload.py - Uploads the patchset dependency, if it exists, to Rietveld (Rietveld will be able to parse this when https://codereview.chromium.org/1155513002/ lands). * rietveld.py - Adds utility methods to get patchset dependencies from the new Rietveld endpoint (the endpoint will exist when https://codereview.chromium.org/1155513002/ lands). * apply_issue.py - If CL3 depends on CL2 which in turn depends on CL1 then apply_issue will gather a list of all issues and patchsets to apply (Eg: [CL1:PS1, CL2:PS1, CL3:PS2]). apply_issue will then loop over the list applying each dependency. Note: The apply_issue.py diff looks much worse than it is. Please see my comment in https://codereview.chromium.org/1149653002/diff/260001/apply_issue.py#oldcode169 Tested end-to-end using a test Git repository (https://skia.googlesource.com/skiabot-test/) and the following CLs created in my test Rietveld instance: * https://skia-codereview-staging.appspot.com/931002 ('Branch1 CL') * https://skia-codereview-staging.appspot.com/5001001 ('Branch2 CL') * https://skia-codereview-staging.appspot.com/9881001 ('Branch3 CL') * https://skia-codereview-staging.appspot.com/3951001 ('Branch3.1 CL') Opt into the new UI and observe the new 'Depends on Patchset' and 'Dependent Patchsets' sections in the above CLs. Design doc is here: https://docs.google.com/document/d/1KZGFKZpOPvco81sYVRCzwlnjGctup71RAzY0MSb0ntc/edit#heading=h.6r6lt4tsvssw BUG=502255 Review URL: https://codereview.chromium.org/1149653002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295778 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Apr, 2015 1 commit
-
-
vadimsh@chromium.org authored
It is done in preparation for switching to OAuth2 as default (and only) authentication method. Having all auth options handled by the same code makes it easier to gradually add OAuth2 support. As part of this, some options that would no longer work with OAuth2 (and that are not being used from anywhere now, as far as I can tell) are removed: * Passing account password for authentication via command line. * Overriding 'Host' header when making requests to Rietveld (won't work with SSL anyway). * --account_type option (seems to be ClientLogin specific). R=maruel@chromium.org BUG=356813 Review URL: https://codereview.chromium.org/1075723002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294746 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Feb, 2015 1 commit
-
-
sbc@chromium.org authored
Handle KeyboardInterrupt gracefully rather the printing a backtrace. Most users of these tools don't expect a backtrace when then hit Ctrl-C. Also, fix a few other inconsistencies found in the python startup code of these different scripts: - always call main function 'main' (rather than 'Main') - always return 0 from main function - if main takes args never include argv[0] Review URL: https://codereview.chromium.org/955993006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294250 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Jul, 2014 1 commit
-
-
hinoka@chromium.org authored
We changed apply_issue to stage the patch if its on git, so it doesn't make sense to pass in --revision because that causes gclient to run solutions in managed mode. BUG=388374 Review URL: https://codereview.chromium.org/359443003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@280855 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 May, 2014 3 commits
-
-
hinoka@chromium.org authored
For a bot_update Git world, we don't really want to commit patches. Instead we just want to leave them unstaged. BUG=370503 Review URL: https://codereview.chromium.org/280063003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@269489 0039d316-1c4b-4281-b951-d872f2087c98
-
hinoka@chromium.org authored
Revert of Have apply_patch.py/checkout.py stage git patches instead of committing them (https://codereview.chromium.org/273543002/) Reason for revert: Borked all the tryjobs due to missing --base_ref, needed to land with https://codereview.chromium.org/273543002/ Original issue's description: > Have apply_patch.py/checkout.py stage git patches instead of committing them > > For a bot_update Git world, we don't really want to commit patches. Instead > we just want to leave them unstaged. > > BUG=370503 > TEST=ran locally with and without flag > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=269468 TBR=maruel@chromium.org,agable@chromium.org,hinoka@google.com,iannucci@chromium.org NOTREECHECKS=true NOTRY=true BUG=370503 Review URL: https://codereview.chromium.org/271283003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@269482 0039d316-1c4b-4281-b951-d872f2087c98
-
hinoka@chromium.org authored
For a bot_update Git world, we don't really want to commit patches. Instead we just want to leave them unstaged. BUG=370503 TEST=ran locally with and without flag Review URL: https://codereview.chromium.org/273543002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@269468 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 May, 2014 1 commit
-
-
hinoka@chromium.org authored
BUG=370503 TESTS= apply_issue.py --issue 243483007 --patchset 210001 --whitelst chrome/browser/chromeos/login/screen_locker.cc apply_issue.py --issue 243483007 --patchset 210001 --blacklist chrome/browser/chromeos/login/screen_locker.cc Review URL: https://codereview.chromium.org/264823003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@268589 0039d316-1c4b-4281-b951-d872f2087c98
-
- 21 Apr, 2014 1 commit
-
-
hinoka@google.com authored
Bot_update takes care of running gclient sync after apply_issue, so this is unnecessary. BUG= Review URL: https://codereview.chromium.org/242433002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@265031 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Mar, 2014 1 commit
-
-
pgervais@chromium.org authored
Added oauth2client and httplib to third_party BUG=348233 Review URL: https://codereview.chromium.org/183793010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259643 0039d316-1c4b-4281-b951-d872f2087c98
-
- 19 Mar, 2014 1 commit
-
-
agable@chromium.org authored
Review URL: https://codereview.chromium.org/204013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@257841 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 Mar, 2014 1 commit
-
-
agable@chromium.org authored
This prevents apply_patch from attempting to check out a branch tracking 'origin/None'. R=pgervais@chromium.org Review URL: https://codereview.chromium.org/202483008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@257763 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 Feb, 2014 1 commit
-
-
hinoka@google.com authored
This is to tackle the issue that slaves don't have global git vars set up. BUG=339171 Review URL: https://codereview.chromium.org/175543006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@252705 0039d316-1c4b-4281-b951-d872f2087c98
-
- 21 Feb, 2014 1 commit
-
-
hinoka@google.com authored
This add --force to ignore the flag file. This also passes --base_ref so we can specify which ref we're basing off of so that it does not incorrectly assert that it is basing off origin/master BUG=339171 Review URL: https://codereview.chromium.org/171763003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@252464 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 Nov, 2013 1 commit
-
-
stip@chromium.org authored
BUG=170427 Review URL: https://codereview.chromium.org/60613005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@236101 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Oct, 2013 1 commit
-
-
rmistry@google.com authored
BUG=chromium:303433 Review URL: https://chromiumcodereview.appspot.com/25853003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@226774 0039d316-1c4b-4281-b951-d872f2087c98
-
- 05 Sep, 2013 1 commit
-
-
rmistry@google.com authored
Tested with: * Unit tests have been added and they work. * I also tested end-to-end using a skiabot-test repository in https://skia.googlesource.com/ (it is hidden). CLs I tested with are: ** https://codereview.chromium.org/22797006/ : Add whitespace in file1 ** https://codereview.chromium.org/22815013/ : Remove whitespace from file1 ** https://codereview.chromium.org/22867025/ : Add new files in directories ** https://codereview.chromium.org/22901018/ : Edit file in directory and delete file in directory ** https://codereview.chromium.org/22918014/ : Add, Delete and Modify 3 files ** https://codereview.chromium.org/23360004/ : Add new files in new directories Note: * When committing GitCheckout uses the --author to specify the original author. The author flag takes in 'Firstname Lastname <email_addr>' but we do not know the Firstname and LastName of the original author, which is why the code here parses out the username from the email address and uses it. Eg: For email address xyz@example.com it passes in --author 'xyz <xyz@example.com>' * An example of the changes required in a project to use GitCheckout instead of SvnCheckout is in https://codereview.chromium.org/22859063/ Created to fix the following feature requests- https://code.google.com/p/chromium/issues/detail?id=261619 : Update the Chrome commit queue to push to src.git. https://code.google.com/p/skia/issues/detail?id=1593 : Add Git support to the Commit Queue. Review URL: https://chromiumcodereview.appspot.com/22794015 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@221392 0039d316-1c4b-4281-b951-d872f2087c98
-
- 27 Jul, 2013 1 commit
-
-
ilevy@chromium.org authored
Add an option to apply_issue to fail if anonymous access triggers a login prompt. - cherry-pick upload.py rietveld cl 37c73ece82d0 which allows clients to request no authentication. BUG=240634 Review URL: https://chromiumcodereview.appspot.com/20634003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@214023 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Jun, 2013 2 commits
-
-
iannucci@chromium.org authored
This reverts commit 012dc07c. Revert "Partially revert r208574 to get the CQ working again (hopefully)." This reverts commit 74105cd2. Pull the --no-commit change out completely. TBR=dpranke@chromium.org BUG=254556 Review URL: https://codereview.chromium.org/17944002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@208801 0039d316-1c4b-4281-b951-d872f2087c98
-
dpranke@chromium.org authored
TBR=iannucci@chromium.org, cmp@chromium.org BUG=254556 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@208782 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 Jun, 2013 1 commit
-
-
iannucci@chromium.org authored
R=dpranke@chromium.org BUG= Review URL: https://codereview.chromium.org/17644004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@208574 0039d316-1c4b-4281-b951-d872f2087c98
-
- 29 Apr, 2013 1 commit
-
-
maruel@chromium.org authored
Without this change, if an entry is removed from a DEPS file, it won't be effectively deleted. Specify --delete_unversioned_trees so the dependency is properly deleted. TBR=szager@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/14531006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@197081 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Nov, 2012 1 commit
-
-
maruel@chromium.org authored
Otherwise the try slaves run the hooks twice, once in the apply_issue, another in the runhooks step. It is unnecessary. It will reduce the problem with apply_issue timeouts. TBR=xusydoc@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/11362176 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166826 0039d316-1c4b-4281-b951-d872f2087c98
-
- 07 Nov, 2012 1 commit
-
-
maruel@chromium.org authored
apply_issue step hangs and the output is often in the reverse order. This CL is to help diagnose the problem. TBR=cmp@chromium.org BUG=159868 Review URL: https://chromiumcodereview.appspot.com/11359093 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166505 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Nov, 2012 1 commit
-
-
maruel@chromium.org authored
TBR=cmp@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/11366030 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@165354 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 Oct, 2012 1 commit
-
-
maruel@chromium.org authored
TBR=rogerta@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/11235034 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@163342 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Oct, 2012 4 commits
-
-
maruel@chromium.org authored
The object creation order was wrong TBR=rogerta@chromium.org BUG=149941 Review URL: https://chromiumcodereview.appspot.com/11024009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159524 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Stop using stderr so the output is more readable on buildbot. Otherwise stderr arrives before stdout in apply_issue step. TBR=rogerta@chromium.org BUG=153284 Review URL: https://chromiumcodereview.appspot.com/11038002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159508 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
It's to help users figuring out what is happening. TBR=rogerta@chromium.org BUG=153284 Review URL: https://chromiumcodereview.appspot.com/11028002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159504 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
TBR=rogerta@chromium.org BUG=153284 Review URL: https://chromiumcodereview.appspot.com/11019015 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159488 0039d316-1c4b-4281-b951-d872f2087c98
-
- 21 Sep, 2012 1 commit
-
-
rogerta@chromium.org authored
BUG=149941 Review URL: https://chromiumcodereview.appspot.com/10958049 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@158068 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 Sep, 2012 1 commit
-
-
rogerta@chromium.org authored
can be applied. This is the first part for this bug; the second part is in commands.py where this is called by the TS. BUG=149941 Review URL: https://chromiumcodereview.appspot.com/10917306 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@157355 0039d316-1c4b-4281-b951-d872f2087c98
-