- 28 Jul, 2017 1 commit
-
-
Dan Jacques authored
Have the "update_depot_tools" script also do a CIPD tool sync. This will ensure that users and systems have access to tooling at sync-time rather than just-in-time loading them at execution time. Update the tool boostraps to suppress any sort of syncing logs, if it does happen. This will ensure that users who execute the tools don't see unexpected output. BUG=chromium:748651 TEST=local - Tested on Mac and Windows. Change-Id: I1aad897d885a07beeac40a372a658681720efd2a Reviewed-on: https://chromium-review.googlesource.com/591229 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
- 27 Jul, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
This is an exact reland of https://chromium-review.googlesource.com/583617 . One of the main use cases is making it clear which revision hashes need to be changed together. The way it's usually done is one variable referenced several times. With this CL, we preserve the references from original DEPS, as opposed to evaluating them and losing some info. This CL actually makes Var() emit a variable placeholder instead of its value, and adds support for these placeholders to gclient. One of possible next steps might be to deprecate Var(). Bug: 570091, 748486 Change-Id: Id47e3771b7163149a4cd427b84f84ece52772f34 Reviewed-on: https://chromium-review.googlesource.com/586594Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
William Hesse <whesse@google.com> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 26 Jul, 2017 1 commit
-
-
Dirk Pranke authored
This reverts commit 4d92fe43. Reason for revert: This moved the logging from invoking `led` or `vpython` to whenever someone would run something that would end up invoking `update_depot_tools`. It's good that we are calling this when we run update_depot_tools, but we probably should've suppressed the logging there in at least the success case, because now things are even more confusing. See crbug.com/748651. Original change's description: > [bootstraps] Sync at gclient, suppress output. > > Have the "update_depot_tools" script also do a CIPD tool sync. This will > ensure that users and systems have access to tooling at sync-time rather > than just-in-time loading them at execution time. > > Update the tool boostraps to suppress any sort of syncing logic, if it > does happen. This will ensure that users who execute the tools don't se > unexpected output. > > BUG=None > TEST=local > - Tested on Mac and Windows. > > R=dpranke@chromium.org, iannucci@chromium.org > > Change-Id: I8efce8c73cc4e82ffdf5067ba9b917119a81e843 > Reviewed-on: https://chromium-review.googlesource.com/581494 > Commit-Queue: Daniel Jacques <dnj@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> TBR=iannucci@chromium.org,dpranke@chromium.org,dnj@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: None Change-Id: I2485c9dd2e48a8dbdeebfff5da9d4c708e0edcb7 Reviewed-on: https://chromium-review.googlesource.com/585867Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org>
-
- 25 Jul, 2017 2 commits
-
-
Paweł Hajdan Jr authored
This reverts commit e79ddeaa. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=748486 Original change's description: > gclient flatten: preserve variable placeholders > > One of the main use cases is making it clear which revision hashes > need to be changed together. The way it's usually done is one variable > referenced several times. With this CL, we preserve the references > from original DEPS, as opposed to evaluating them and losing some info. > > This CL actually makes Var() emit a variable placeholder > instead of its value, and adds support for these placeholders > to gclient. > > One of possible next steps might be to deprecate Var(). > > Bug: 570091 > Change-Id: I9b13a691b5203cc284c33a59438720e31c9ebf7a > Reviewed-on: https://chromium-review.googlesource.com/583617 > Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> TBR=phajdan.jr@chromium.org,dpranke@chromium.org Change-Id: If9c52ebfa78aba8041ce797ff842d09952d0e2ce No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 570091, 748486 Reviewed-on: https://chromium-review.googlesource.com/584907Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
Paweł Hajdan, Jr authored
One of the main use cases is making it clear which revision hashes need to be changed together. The way it's usually done is one variable referenced several times. With this CL, we preserve the references from original DEPS, as opposed to evaluating them and losing some info. This CL actually makes Var() emit a variable placeholder instead of its value, and adds support for these placeholders to gclient. One of possible next steps might be to deprecate Var(). Bug: 570091 Change-Id: I9b13a691b5203cc284c33a59438720e31c9ebf7a Reviewed-on: https://chromium-review.googlesource.com/583617 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org>
-
- 24 Jul, 2017 2 commits
-
-
Dan Jacques authored
Have the "update_depot_tools" script also do a CIPD tool sync. This will ensure that users and systems have access to tooling at sync-time rather than just-in-time loading them at execution time. Update the tool boostraps to suppress any sort of syncing logic, if it does happen. This will ensure that users who execute the tools don't se unexpected output. BUG=None TEST=local - Tested on Mac and Windows. R=dpranke@chromium.org, iannucci@chromium.org Change-Id: I8efce8c73cc4e82ffdf5067ba9b917119a81e843 Reviewed-on: https://chromium-review.googlesource.com/581494 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
Paweł Hajdan, Jr authored
Added a regression test. Simplified some logic - if we don't add os-specific deps and hooks to |dependencies|, we don't need to keep separate original values. Bug: 570091 Change-Id: I5bdd0b6a66df6b3a2b99d0ad9c6e54ee7114f09b Reviewed-on: https://chromium-review.googlesource.com/581687 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org>
-
- 07 Jul, 2017 3 commits
-
-
Paweł Hajdan, Jr authored
This needs an update after simultaneous landing of https://chromium-review.googlesource.com/c/561681/ and https://chromium-review.googlesource.com/c/562138/ . TBR=dpranke Bug: 570091 Change-Id: I35ba4fa95ee97a8059eedf5ebf13b09b1c5ee89c Reviewed-on: https://chromium-review.googlesource.com/563196Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: Ibf7c6a73cab8bb777a7e4a8d958f085238c76450 Reviewed-on: https://chromium-review.googlesource.com/562138Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
Paweł Hajdan, Jr authored
ChromeOS build depends on buildspec_platforms variable, see https://bugs.chromium.org/p/chromium/issues/detail?id=703268 . Bug: 570091 Change-Id: I9c964d332b45cf10f5cb79a82ea721bd4aba80d3 Reviewed-on: https://chromium-review.googlesource.com/561681Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 06 Jul, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I4fac33ca683ff2011fa7307d5175592f3d9e258e Reviewed-on: https://chromium-review.googlesource.com/560171Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 03 Jul, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I96417d462efb3b0476ee17d42ac5f19d8c4f99c3 Reviewed-on: https://chromium-review.googlesource.com/558352Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 29 Jun, 2017 2 commits
-
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: Ib1a86289f8219ead789e19896c2a873b8d59c179 Reviewed-on: https://chromium-review.googlesource.com/556035Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
Michael Moss authored
R=dpranke@chromium.org, phajdan.jr@chromium.org Bug: 570091 Change-Id: Ic2aa1a9fe18f3fe8d5aa6fa4c4e9269106b36092 Reviewed-on: https://chromium-review.googlesource.com/553719 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Di Mu <dimu@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 27 Jun, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: Ia7f81a81d7df75004c5f8b7560dfd50a14f4cddd Reviewed-on: https://chromium-review.googlesource.com/549355 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org>
-
- 26 Jun, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: Iae9dad68a75d751ceac6379baac588f32c59aa06 Reviewed-on: https://chromium-review.googlesource.com/548935Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 23 Jun, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I5a489f9f9cbc5384b720685264aa918573234cf5 Reviewed-on: https://chromium-review.googlesource.com/544965Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 21 Jun, 2017 3 commits
-
-
Paweł Hajdan, Jr authored
This is a reland of https://chromium-review.googlesource.com/c/541280/ with a fix for https://bugs.chromium.org/p/chromium/issues/detail?id=735418 (patchset 1 is original patch, patchset 2 has the fix). Keep deps_os entries in dependencies, just with should_process set to False for entries not applicable to target OS list. This way gclient flatten has proper access to dependencies e.g. to evaluate recursedeps referring to deps_os entries other than active OS. Allow but ignore deps_os overriding a value with None, since that does not fit the new model. There's no correctness harm in not checking out a repo. Allow "overrides" setting given dependency to the same value. This seems fairly common, especially for mac/ios and unix/android, even in chromium/src. Bug: 570091, 735418 Change-Id: I6eba0e4be202212eb86cb959c18f2b2f0c1452b9 Reviewed-on: https://chromium-review.googlesource.com/543076 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
This reverts commit 529d6a4e. Reason for revert: broke developers and CI/Try checkouts. Bug: 735418 Original change's description: > gclient: include deps_os entries in dependencies > > Keep deps_os entries in dependencies, just with should_process set to False > for entries not applicable to target OS list. > > This way gclient flatten has proper access to dependencies e.g. to evaluate > recursedeps referring to deps_os entries other than active OS. > > Allow but ignore deps_os overriding a value with None, since that does not > fit the new model. There's no correctness harm in not checking out a repo. > > Allow "overrides" setting given dependency to the same value. This seems > fairly common, especially for mac/ios and unix/android, even in chromium/src. > > Bug: 570091 > Change-Id: I2037a1ecc5fd2da6b5f73061548b81fc79ba2e72 > Reviewed-on: https://chromium-review.googlesource.com/541280 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> TBR=phajdan.jr@chromium.org,dpranke@chromium.org Change-Id: Iaa0c39865908a5b25c15dda54ba61c0e76abcbea No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 570091 Reviewed-on: https://chromium-review.googlesource.com/543138Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Paweł Hajdan, Jr authored
Keep deps_os entries in dependencies, just with should_process set to False for entries not applicable to target OS list. This way gclient flatten has proper access to dependencies e.g. to evaluate recursedeps referring to deps_os entries other than active OS. Allow but ignore deps_os overriding a value with None, since that does not fit the new model. There's no correctness harm in not checking out a repo. Allow "overrides" setting given dependency to the same value. This seems fairly common, especially for mac/ios and unix/android, even in chromium/src. Bug: 570091 Change-Id: I2037a1ecc5fd2da6b5f73061548b81fc79ba2e72 Reviewed-on: https://chromium-review.googlesource.com/541280Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 14 Jun, 2017 2 commits
-
-
Paweł Hajdan, Jr authored
This makes it possible to run hooks properly in flattened DEPS. Bug: 570091 Change-Id: If8175a57ebe8f607bd4ac83d4a26dcc4cc18165c Reviewed-on: https://chromium-review.googlesource.com/535476Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I3b9fc0560bf744efed9e7f6d9a6595477cffbf8d Reviewed-on: https://chromium-review.googlesource.com/534393Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 07 Jun, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I5c7cf00722c47a2063a8635822c0bb270a26b524 Reviewed-on: https://chromium-review.googlesource.com/527632 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org>
-
- 06 Jun, 2017 2 commits
-
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: Ib2b966b5bc967de11a295b1636c1901faabea55f Reviewed-on: https://chromium-review.googlesource.com/525540 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org>
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: Id95be31767d302c5eb9f7de96d31e32cc4dec1a4 Reviewed-on: https://chromium-review.googlesource.com/524492Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 18 May, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
This is based on https://codereview.chromium.org/2474543002/ Bug: 661382 Change-Id: I191ec16e0ce69a782979ae7d59b108747429ab78 Reviewed-on: https://chromium-review.googlesource.com/505067 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org>
-
- 16 May, 2017 1 commit
-
-
Michael Achenbach authored
This reverts commit 2c199e1e. Reason for revert: This makes calls to gclient that have the only intention of updating gclient fail, like: https://cs.chromium.org/chromium/src/v8/tools/try_perf.py?l=93 Reverting for now to give time to clean up such scripts before reland. Original change's description: > gclient: return non-zero exit code on unknown command > > Bug: none > Change-Id: I447f66765679b7b66b5748af1cf1f501610603bf > Reviewed-on: https://chromium-review.googlesource.com/504408 > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> > TBR=iannucci@chromium.org,phajdan.jr@chromium.org,dpranke@chromium.org,tandrii@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: none Change-Id: I9496f7192dfde1e38c186a94ac985190b76b2438 Reviewed-on: https://chromium-review.googlesource.com/506563Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
-
- 15 May, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
Bug: none Change-Id: I447f66765679b7b66b5748af1cf1f501610603bf Reviewed-on: https://chromium-review.googlesource.com/504408Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 19 Mar, 2017 1 commit
-
-
Robert Iannucci authored
BUG=670678 Change-Id: If3104a6d666e84d7150ba805672dac3e34a1f9a1 Reviewed-on: https://chromium-review.googlesource.com/416269 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org>
-
- 21 Dec, 2016 1 commit
-
-
agable authored
R=maruel@chromium.org BUG=641588 Review-Url: https://codereview.chromium.org/2401483002
-
- 16 Dec, 2016 1 commit
-
-
Quinten Yearsley authored
This affects a bunch of files, but only changes comments, and shouldn't make any difference to behavior. The purpose is to slightly improve readability of pylint disable comments. Change-Id: Ic6cd0f8de792b31d91c6125f6da2616450b30f11 Reviewed-on: https://chromium-review.googlesource.com/420412Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
-
- 15 Nov, 2016 1 commit
-
-
agable authored
R=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2395013002
-
- 20 Oct, 2016 1 commit
-
-
agable authored
This removes SVN support (most notably the SVNWrapper class, and the git-svn logic in GitWrapper.GetUsableRev) from gclient_scm. It also removes some references to SVN from comments in gclient_utils. R=maruel@chromium.org BUG=641588 Review-Url: https://chromiumcodereview.appspot.com/2393773003
-
- 18 Jul, 2016 1 commit
-
- 28 Jun, 2016 1 commit
-
-
agable authored
BUG=339055 R=hinoka@chromium.org Review-Url: https://codereview.chromium.org/2099153003
-
- 24 Jun, 2016 1 commit
-
-
agable authored
R=maruel@chromium.org BUG=109184 Review-Url: https://codereview.chromium.org/2087313002
-
- 12 Nov, 2015 2 commits
-
-
iannucci@chromium.org authored
Revert of git_cl/gclient: use python2 (patchset #3 id:40001 of https://codereview.chromium.org/1437773002/ ) Reason for revert: breaks git-bash on windows Original issue's description: > git_cl/gclient: use python2 > > Newer distros are defaulting /usr/bin/python to python3, so use python2 > explicitly so we continue working. > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297535 TBR=stip@chromium.org,sergeyberezin@chromium.org,vapier@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1442583004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297544 0039d316-1c4b-4281-b951-d872f2087c98
-
vapier@chromium.org authored
Newer distros are defaulting /usr/bin/python to python3, so use python2 explicitly so we continue working. Review URL: https://codereview.chromium.org/1437773002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297535 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Jun, 2015 1 commit
-
-
sbc@chromium.org authored
Allows the command line itself to be distinguished from the surrounding error message. Review URL: https://codereview.chromium.org/1152443004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295481 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 May, 2015 1 commit
-
-
maruel@chromium.org authored
Subversion usage is going away, tests get the kick first. R=iannucci@chromium.org BUG=475320 Review URL: https://codereview.chromium.org/1158043003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295411 0039d316-1c4b-4281-b951-d872f2087c98
-