TEST=none
BUG=none
TBR=maruel

Review URL: http://codereview.chromium.org/126057

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18279 0039d316-1c4b-4281-b951-d872f2087c98

I had used the old method name. watchlists needs a unit test.

TEST=none
BUG=none
TBR=nirnimesh

Review URL: http://codereview.chromium.org/125053

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18278 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
TBR=nirnimesh

Review URL: http://codereview.chromium.org/126051

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18274 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/126050

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18273 0039d316-1c4b-4281-b951-d872f2087c98

Small refactor of ChangeInfo to not hardcode the use of GetRepositoryRoot().

TEST=unit tests
BUG=none

Review URL: http://codereview.chromium.org/125051

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18272 0039d316-1c4b-4281-b951-d872f2087c98

Stop presubmit_support.py from calling gcl.GetRepositoryRoot(). Instead, save the repository root in ChangeInfo and name it GetLocalRoot() to make it less confusing.
Add GetFileList() and GetFileNames() to ChangeInfo to make it less confusing and more "interface-like".

TEST=updated unit tests with a lot of pain
BUG=none

Review URL: http://codereview.chromium.org/119442

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18266 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/126032

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18265 0039d316-1c4b-4281-b951-d872f2087c98

TESTS=still none
BUG=none
TBR=nirnimesh

Review URL: http://codereview.chromium.org/126031

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18245 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18244 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
R=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18238 0039d316-1c4b-4281-b951-d872f2087c98

Will reapply in 3 days.

TEST=gcl try works.
BUG=none
TBR=nsylvain
Review URL: http://codereview.chromium.org/126020

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18232 0039d316-1c4b-4281-b951-d872f2087c98

Watchlists provides an opportunity for someone interested in a particular
code section to make comments before commit. One can subscribe to watchlists
depending on filepath (regular expressions) and she'll automatically get
cc-ed to changes when the watchlist is triggered.

Additional examples of watchlist_rules in diff repo:
http://codereview.chromium.org/118431
http://codereview.chromium.org/119356
Review URL: http://codereview.chromium.org/118432

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18209 0039d316-1c4b-4281-b951-d872f2087c98

Don't rely on the freaky tryserver.py script anymore. Use gcl codereview settings instead.

TEST=gcl try still works, shouldn't break git-try
BUG=none

Review URL: http://codereview.chromium.org/123020

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18198 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18179 0039d316-1c4b-4281-b951-d872f2087c98

Remove old unused git-cl test files.

TEST=unit tests
BUG=none

Review URL: http://codereview.chromium.org/122040

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18177 0039d316-1c4b-4281-b951-d872f2087c98

This is annoying when using gcl presubmit.

TEST=unit test
BUG=none
Review URL: http://codereview.chromium.org/122010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18141 0039d316-1c4b-4281-b951-d872f2087c98

Add some regexp unit test.

TEST=unit test
BUG=none

Review URL: http://codereview.chromium.org/118530

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18139 0039d316-1c4b-4281-b951-d872f2087c98

Fix GclChangeInfo.__getattr__ to only accept uppercase tags.
Rename illnamed GclChangeInfo.Change() to GclChangeInfo.Name().
Fix random comments.

TEST=unit test
BUG=none

Review URL: http://codereview.chromium.org/122016

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18138 0039d316-1c4b-4281-b951-d872f2087c98

It's better to strip it off.

TEST=none
BUG=none
TBR=nsylvain

Review URL: http://codereview.chromium.org/122009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18123 0039d316-1c4b-4281-b951-d872f2087c98

TEST=unit tests
BUG=none

Review URL: http://codereview.chromium.org/118527

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18081 0039d316-1c4b-4281-b951-d872f2087c98

TEST=unit test
BUG=none

Review URL: http://codereview.chromium.org/118525

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18079 0039d316-1c4b-4281-b951-d872f2087c98

Stop showing "Presubmit errors, can't continue (use --no_presubmit to bypass)" when running gcl presubmit!

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/119436

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18078 0039d316-1c4b-4281-b951-d872f2087c98

TEST=unit test
BUG=none

Review URL: http://codereview.chromium.org/119427

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18077 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/118521

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18076 0039d316-1c4b-4281-b951-d872f2087c98

TEST=unit tests
BUG=none

Review URL: http://codereview.chromium.org/118505

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18075 0039d316-1c4b-4281-b951-d872f2087c98

TEST=unit test
BUG=none

Review URL: http://codereview.chromium.org/119433

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18074 0039d316-1c4b-4281-b951-d872f2087c98

The output is only shown when it's failing. It makes the presubmit check much cleaner.
Also rename TestDescription and TestContent that were ill named.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/118415

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18055 0039d316-1c4b-4281-b951-d872f2087c98

Disable prompting when using gcl presubmit xxx.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/118498

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18054 0039d316-1c4b-4281-b951-d872f2087c98

TEST=unit tests
BUG=none

Review URL: http://codereview.chromium.org/119421

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18053 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/119365

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17975 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/118451

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17974 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise, all the parameters are coagulated into a single one.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/119308

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17968 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/118416

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17937 0039d316-1c4b-4281-b951-d872f2087c98

Factor out some code in FilterFlag() to make the code much more readable.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/119315

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17884 0039d316-1c4b-4281-b951-d872f2087c98

ReadFile limits to reading files inside the repository.
CheckChangeHasNoCR reads the text files looking for \r and fails if found.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/118370

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17857 0039d316-1c4b-4281-b951-d872f2087c98

Check if the given root path argument points to a valid directory. Display an error message and quit if it is not.

Review URL: http://codereview.chromium.org/118379

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17856 0039d316-1c4b-4281-b951-d872f2087c98

PathDifference cuts a supplied "root path" from a second path and returns what remains. It is assumed that this can be used as a relative path from the "root path" to the second path.

If the root path ends with a path separator (\ or /), the function used to cut an additional character from the path and the returned value would be incorrect. This fix makes sure the behavior is consistent and correct no matter if the root path ends with a separator or not.

(This fixes the "epot_tools" tools bug.)
Review URL: http://codereview.chromium.org/118376

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17855 0039d316-1c4b-4281-b951-d872f2087c98

This is needed if you do not have VS in your PATH on purpose and makes life easy if you do not have it there by accident.

Review URL: http://codereview.chromium.org/112098

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17854 0039d316-1c4b-4281-b951-d872f2087c98

git-cl is broken

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17844 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/119286

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17841 0039d316-1c4b-4281-b951-d872f2087c98