- 16 May, 2017 11 commits
-
-
Wei-Yin Chen (陳威尹) authored
This makes it easier to add options to this script. There should be no functional changes except for slightly different text output. Change-Id: I4d68a8c4aa0c159eae9435fe962e53f6f09d2d47 Reviewed-on: https://chromium-review.googlesource.com/499527 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
-
Andrii Shyshkalov authored
R=agable@chromium.org,sergeyberezin@chromium.org,iannucci@chromium.org BUG=722853 Change-Id: I9bd8c259a87cc65e320e99d9c5e18838b970d543 Reviewed-on: https://chromium-review.googlesource.com/505495Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/3343170e687e1cfa402e70c6e90019f9f88f913f [package.py] prevent overriding undeclared repo dependency. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ifb8cdb6411ae501b8c967fe780571eb6a875a9ae Reviewed-on: https://chromium-review.googlesource.com/505440Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Michael Achenbach authored
This reverts commit 2c199e1e. Reason for revert: This makes calls to gclient that have the only intention of updating gclient fail, like: https://cs.chromium.org/chromium/src/v8/tools/try_perf.py?l=93 Reverting for now to give time to clean up such scripts before reland. Original change's description: > gclient: return non-zero exit code on unknown command > > Bug: none > Change-Id: I447f66765679b7b66b5748af1cf1f501610603bf > Reviewed-on: https://chromium-review.googlesource.com/504408 > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> > TBR=iannucci@chromium.org,phajdan.jr@chromium.org,dpranke@chromium.org,tandrii@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: none Change-Id: I9496f7192dfde1e38c186a94ac985190b76b2438 Reviewed-on: https://chromium-review.googlesource.com/506563Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/1a90c2644e03337ecfd91dd1e76a7c2713b42808 [platform] improve testing assertions. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ic9dc336b8df3651d928628d07f22a3f675efa21d Reviewed-on: https://chromium-review.googlesource.com/505556Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/ea1ac7522268ac435550c701790fd1276f3e6a05 [post_process] make the check function return True if the expression is (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: If7a208614fb52b33108907bd274ce1fa9b44a833 Reviewed-on: https://chromium-review.googlesource.com/505871Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/def1c0f3b0bc9712e87e58031eb08e967e7ee46c [test] improve test failure message with retraining instructions. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I0c21757c3859b9a24cc1535e0d762900aaa3e6ce Reviewed-on: https://chromium-review.googlesource.com/505632Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Dan Jacques authored
The Git wrapper now implicitly retries, so this call is unnecessary. BUG=chromium:721450 TEST=None R=hinoka@chromium.org, iannucci@chromium.org Change-Id: I79e42aa050f6fec14506b685d379a76e8296fea3 Reviewed-on: https://chromium-review.googlesource.com/506493Reviewed-by: Ryan Tseng <hinoka@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/b5078f1d18d40c1e8e073ca0e17c6ac382ddcb57 [test] Don't print coverage version by default. (dnj@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I050d1692bf3ade52b35d91e94f060bacc0ffa7b8 Reviewed-on: https://chromium-review.googlesource.com/505533Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Dan Jacques authored
Currently, when the Infra Git wrapper is installed in PATH and a user calls "git retry", the "git_retry.py" script is supposed to ignore the request and fall through to the underlying command, relying on the Git wrapper to handle retries. However, Git apparently prepends its own executable path to PATH when it is called, preventing the Git wrapper from being invoked the second time and removing retries altogether. We circumvent this by removing Git's new PATH influence when falling through. BUG=chromium:721450 TEST=local - Ran locally before and after patch, confirmed that after successfully retries throgh the wrapper. R=agable@chromium.org, iannucci@chromium.org Change-Id: Iae3d7a8bf805a5ba2bf827b06006a990d94e96d9 Reviewed-on: https://chromium-review.googlesource.com/506374Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/9be63aeb7800439b172aaf2d77a156ff5d523947 [context] Fix "check_type" error. (dnj@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I06b8c9d6786dd480f3079251ca8e238ba6163830 Reviewed-on: https://chromium-review.googlesource.com/505532Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
- 15 May, 2017 4 commits
-
-
Aaron Gable authored
If every file in a change has OWNERS, then the code would find them fine. Similarly, if no files has OWNERS, then this code would return an empty set just fine. But if some files had OWNERS while others didn't, it would crash when it tried to find an OWNER for file 'foo' while all the possible OWNERS only provided coverage for file 'bar'. This code purges the list of possible OWNERS as they become useless for providing additional coverage, and returns whatever set we have accumulated so far when the set of possible OWNERS becomes empty. R=iannucci@chromium.org Bug: 715062 Change-Id: I408601bd89379381db1cc7df56beed97ab3c27e6 Reviewed-on: https://chromium-review.googlesource.com/506239 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
-
Dan Jacques authored
Roll "vpython" to: 00f5394a90dfa98e53e191d5a6b543bce70c295f BUG=None TEST=None TBR=iannucci@chromium.org Change-Id: Ia8b5d29a916fb186bdbff9dac4d63526c5f3e2ac Reviewed-on: https://chromium-review.googlesource.com/505930Reviewed-by: Daniel Jacques <dnj@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org>
-
Scott Graham authored
This adds support for 'hooks_os' in .gclient which runs the given hooks only when the associated os is specifed in target_os. Bug: 706592 Change-Id: If70e51e0e784f8a8c6e45b33f59605b883a16f6e Reviewed-on: https://chromium-review.googlesource.com/503534Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
Paweł Hajdan, Jr authored
Bug: none Change-Id: I447f66765679b7b66b5748af1cf1f501610603bf Reviewed-on: https://chromium-review.googlesource.com/504408Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 14 May, 2017 1 commit
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/63fd5fef30ebf0db04266b4f4723f77838979365 [url]: get_file has default (empty) test data (dnj@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I429c5501fa69fdaa4fdf76948663a598e6aee64b Reviewed-on: https://chromium-review.googlesource.com/505530 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
- 13 May, 2017 3 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/e9c7176184ed588bbf66335e834834496f28cf9c [url] Cleanup, bugfix, step_test_data. (dnj@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: If2cace0cf51bbbf68122a4422bd9ff57b2e5168a Reviewed-on: https://chromium-review.googlesource.com/505389 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/0070123d9c8f830d813e6ec1064b9bf24a5b29db [context] Fix docstring. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I0378db40829110017a9b096edcf14153cb450bee Reviewed-on: https://chromium-review.googlesource.com/505529 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
Dan Jacques authored
BUG=None TEST=expectations R=iannucci@chromium.org Change-Id: I43a65405c957cb6dddd64f61846b926d81046752 Reviewed-on: https://chromium-review.googlesource.com/505278Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org>
-
- 12 May, 2017 3 commits
-
-
Aaron Gable authored
R=tandrii@chromium.org Change-Id: I2c669303d2320d672538b363fbb15fb9e5cf37a8 Reviewed-on: https://chromium-review.googlesource.com/505267Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/60cc7f3f49737e8cf852e396b4436c2b6bd3f56d Add vpython support to Python recipe module. (dnj@chromium.org) https://crrev.com/c6560f3627af81c9004024079525ef63a223d33a Add "url" recipe module to base. (dnj@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Iecc732789febe840a4fe42374d8264f5e9ea0f06 Reviewed-on: https://chromium-review.googlesource.com/504967 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/b7c18e0258998652eeb302c83680f6a2b1aee398 Revert of include Package proto into Result proto (patchset #3 id:40001 of https://codereview.chromium.org/2802693003/ ) (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I74e8a446f7cdea5ff6b1784b70ca2ab0ca7c5632 Reviewed-on: https://chromium-review.googlesource.com/503670 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
- 11 May, 2017 9 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/c7d91ef9861b04e41c6a2381382efd58d111fe19 include Package proto into Result proto (nodir@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I716db1f3d8f12fb7d440877cc4fa0ad4d2fe1e77 Reviewed-on: https://chromium-review.googlesource.com/503628 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/6eaacf24833ebd2565177157d368da33780fced9 Fix repeated test 'mkdir' failure. (dnj@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I65d09fa7702f99172a4afae174dcd1236883532a Reviewed-on: https://chromium-review.googlesource.com/503727 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
Robert Iannucci authored
R=recipe-roller@chromium.org Bug: Change-Id: I84c19965b779f1010c00cd8c857b7533eec7413f Reviewed-on: https://chromium-review.googlesource.com/502929Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
Andrii Shyshkalov authored
TBR=machenbach@chromium.org Bug: 717504 Change-Id: Ifa71fa4cac0b57ed11ba5e7eb93516b23b72a496 Reviewed-on: https://chromium-review.googlesource.com/502809Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
Previously landed as: > Change-Id: Ieb6415d55e85b91f11f9052b0fd08cf982b64d51 > Reviewed-on: https://chromium-review.googlesource.com/501849 R=agable@chromium.org,machenbach@chromium.org Bug: 717504 Change-Id: Iede5c29ff4c317b68d8c2bca319edec140a176f5 Reviewed-on: https://chromium-review.googlesource.com/502908 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
-
Andrii Shyshkalov authored
This reverts commit 28a5d5de. Reason for revert: breaks assumption in function for adding footers Original change's description: > Relax git_footers parsing to match that of Gerrit (JGit). > > R=agable@chromium.org > > Bug: 717504 > Change-Id: Ieb6415d55e85b91f11f9052b0fd08cf982b64d51 > Reviewed-on: https://chromium-review.googlesource.com/501849 > Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> > Reviewed-by: Aaron Gable <agable@chromium.org> > TBR=agable@chromium.org,machenbach@chromium.org,tandrii@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: 717504 Change-Id: I9b4d619b2972be8434aff9464f1959fbcb3abd32 Reviewed-on: https://chromium-review.googlesource.com/503030Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I1297f817f2e3d791c22b256de40f12c0c23dceb5 Reviewed-on: https://chromium-review.googlesource.com/500807 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/275cbaae0e81a737ff1be9c73049b2cd124388ad [context] Add user-facing context module. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ib38b90315a8009f38472761e0390a920f7d58fa6 Reviewed-on: https://chromium-review.googlesource.com/502248 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/c594d93e17bd0e32f02620808deed9b1833bd81f [autoroll] Remove support for 'config section' in doc/recipes.py (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I8f6f9ee8f5b82ee3a0565815ca1ec31f0af2ba24 Reviewed-on: https://chromium-review.googlesource.com/502587 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
- 10 May, 2017 6 commits
-
-
Dan Jacques authored
BUG=None TEST=None R=sergeyberezin@chromium.org Change-Id: I2bb22ad002b82767c6a7efb68412f9c1dbf57c27 Reviewed-on: https://chromium-review.googlesource.com/502228Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/23230785ddaec6e199d3ede6d496131ec178c183 config: fix config.Dict with no value type (nodir@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I2cb5dff9c4e745003db3732e23a564272ecedf22 Reviewed-on: https://chromium-review.googlesource.com/502227 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
Andrii Shyshkalov authored
R=agable@chromium.org Bug: 717504 Change-Id: Ieb6415d55e85b91f11f9052b0fd08cf982b64d51 Reviewed-on: https://chromium-review.googlesource.com/501849 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
-
Andrii Shyshkalov authored
R=machenbach@chromium.org BUG=718264 Change-Id: Id238a53dbc22b94010b0eb22263de824da300fbd Reviewed-on: https://chromium-review.googlesource.com/501809Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
Before, git cl creds-check expected `http.cookiefile` of git config to have path without '~' which git understands on Linux/Mac. R=machenbach@chromium.org Bug: 719728 Change-Id: Ica1308b776b62bda7a8b85113c0c0df837c7d933 Reviewed-on: https://chromium-review.googlesource.com/501828Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/c93ed98c3c3e6c9be82e88496e55cb1f3dd13372 [recipe_modules/step] do not set cwd if it is start_dir. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Iba7fa64ddd5485eb52294c610761cd524385787f Reviewed-on: https://chromium-review.googlesource.com/501210 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
- 09 May, 2017 3 commits
-
-
Aaron Gable authored
The old system had two faults: * It set reviewers and ccs via different mechanisms, which is confusing * It set CCs with a single call for each, resulting in N separate emails, with each email going to the uploader and all reviewers and all previous CCs. This new system just collects all reviewers and CCs, and sets them in a single call. That call will fail if *any* of the individual reviewers or ccs fail, so it also parses the response and retries with only the ones which would have succeeded on their own. If that second call fails, or the first fails in an unexpected way, it raises an exception like normal Bug: 710028 Change-Id: I1be508487a41f0b68f9c41908229b8f5342830a3 Reviewed-on: https://chromium-review.googlesource.com/479712 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/9f2573a386ee07450095cbeb3562df94a644962f bootstrap: show a better missing CIPD error (dnj@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ie97ecdd0092bd72f0d0a4226f294a529c4444ab8 Reviewed-on: https://chromium-review.googlesource.com/501047 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/bf2ff828987549b946135919bd1bffd6e42fd8fd [doc/recipes.py] Add option to recipes.py to allow it to work without .git (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I73f11890503702e9af7c24941457425c5cc46267 Reviewed-on: https://chromium-review.googlesource.com/499770 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-