- 01 Nov, 2013 1 commit
-
-
maruel@chromium.org authored
Using "%@" will correctly requote quoted arguments. Tested with repro case. The fix in r232184 missed the necessary argument quoting. R=iannucci@chromium.org BUG=314192 BUG=241769 Review URL: https://codereview.chromium.org/47873010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@232501 0039d316-1c4b-4281-b951-d872f2087c98
-
- 31 Oct, 2013 2 commits
-
-
maruel@chromium.org authored
Tested to work now with the repro case of bug 313552. "/c" was interpreted by cygwin's bash as a path and was replaced with c:/. :( Using //c seems to be passed through properly. There is probably other escaping problem but this should be good enough at this stage. Ref: http://www.mingw.org/wiki/Posix_path_conversion R=iannucci@chromium.org BUG=241769 BUG=313552 Review URL: https://codereview.chromium.org/50143013 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@232184 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
This broke git cl patch due to escaping. I tried removing the double quotes but it didn't work out. Reverting in the meantime to unblock people until I figure out a permanent way. BUG=313552,241769 TBR=iannucci Review URL: https://codereview.chromium.org/50293009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@232112 0039d316-1c4b-4281-b951-d872f2087c98
-
- 30 Oct, 2013 1 commit
-
-
maruel@chromium.org authored
Fix the git-* wrapper scripts, PRESUBMIT.py and .gitignore. The previous python wrapping scripts assumed python_bin\python.exe. This CL modifies the wrapping scripts to use python.bat. This requires some quoting magic and explicitly defer to cmd.exe. This may break some cases where double quotes are used as arguments. We can't do miracles on Windows. R=iannucci@chromium.org BUG= Review URL: https://codereview.chromium.org/50563008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@231888 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 Jun, 2012 1 commit
-
-
chrisha@chromium.org authored
This gets around command-line length limitations. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10654002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@143620 0039d316-1c4b-4281-b951-d872f2087c98
-
- 19 Jun, 2012 1 commit
-
-
chrisha@google.com authored
This CL adds pylint (and its dependencies) to third_party. It plumbs them into presubmit_canned_checks, and exposes a command-line tool to access pylint. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10447014 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@143016 0039d316-1c4b-4281-b951-d872f2087c98
-
- 28 Sep, 2011 1 commit
-
-
maruel@chromium.org authored
Since we clobber the .pyc, it's not useful to generate them in the first place. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8060026 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@103066 0039d316-1c4b-4281-b951-d872f2087c98
-
- 14 Jun, 2011 1 commit
-
-
cmp@chromium.org authored
This mirrors the git-cl changes by first moving git-try to git_try.py (which git cl already had), then copying git-cl to git-try and updating all references to git-cl and git_cl.py to the corresponding git try references. The main issue is that in the MINGW/Msysgit case we want to use the Python in depot_tools since that is 100% compatible with the Command Prompt. Hence we need to call it directly and then pass it the name of the git_try.py script. Note that 'git-try' will not (ever) work on Windows, and users should only ever run 'git try'. Hence the need to modify the output of the command to avoid further confusion. Review URL: http://codereview.chromium.org/7114002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89031 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Nov, 2010 1 commit
-
-
maruel@chromium.org authored
Most of them are style issues or variable aliasing. TEST=Can almost enable pylint warnings BUG=none Review URL: http://codereview.chromium.org/4360002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64908 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 Oct, 2010 1 commit
-
-
joi@chromium.org authored
smarter about finding the most appropriate settings file. Before this change, I inadvertently did a [gcl try] on a chrome-internal change (it was a trivial change and not really secret, so no harm done). After this change, that won't be possible. Also, change breakpad to not upload the exception that is thrown when the user fails to provide correct log-on credentials. TEST=none BUG=none Review URL: http://codereview.chromium.org/3390013 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@61738 0039d316-1c4b-4281-b951-d872f2087c98
-
- 15 Sep, 2010 1 commit
-
-
maruel@chromium.org authored
That fixes the common usage "git-try <branch>" so the diff is generated against a branch. BUG=46697 TEST=none Review URL: http://codereview.chromium.org/3433011 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59550 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Sep, 2010 1 commit
-
-
maruel@chromium.org authored
TBR=bradnelson TEST=git-try works BUG=54084 Review URL: http://codereview.chromium.org/3311021 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58941 0039d316-1c4b-4281-b951-d872f2087c98
-
- 31 May, 2010 1 commit
-
-
maruel@chromium.org authored
Review URL: http://codereview.chromium.org/2408001 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48606 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Feb, 2010 1 commit
-
-
maruel@chromium.org authored
Moved tests/pymox to third_party/pymox Moved upload.py to third_party/upload.py Fixed tests so they can run standalone Fixed the executable bit on some scripts TEST=none BUG=34376 Review URL: http://codereview.chromium.org/562031 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37987 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Feb, 2010 2 commits
-
-
nasser@codeaurora.org authored
Review URL: http://codereview.chromium.org/561001 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37750 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
TEST=none BUG=none TBR=nasser Review URL: http://codereview.chromium.org/548223 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37692 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Jan, 2010 1 commit
-
-
mhm@chromium.org authored
Some external contributors need their CL's try'd quickly, but currently its not easy unless we patch locally. This will allow you to submit the rietveld issue number and will do the rest automatically. As well, renable the dry_run option. It was removed. BUG=None TEST=git try --issue 12345 Review URL: http://codereview.chromium.org/481006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35881 0039d316-1c4b-4281-b951-d872f2087c98
-
- 08 Jan, 2010 1 commit
-
-
maruel@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/536002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35830 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Dec, 2009 1 commit
-
-
maruel@chromium.org authored
TEST=try me (none) BUG=none TBR=brad Review URL: http://codereview.chromium.org/516007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35219 0039d316-1c4b-4281-b951-d872f2087c98
-
- 08 Dec, 2009 1 commit
-
-
maruel@chromium.org authored
Review URL: http://codereview.chromium.org/465128 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34087 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Oct, 2009 1 commit
-
-
shess@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@29220 0039d316-1c4b-4281-b951-d872f2087c98
-
- 15 Oct, 2009 1 commit
-
-
mattm@chromium.org authored
BUG=none TEST=git-try -b linux -b linux_view Review URL: http://codereview.chromium.org/278015 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@29171 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 Oct, 2009 1 commit
-
-
thestig@chromium.org authored
BUG=23071 TEST=none Review URL: http://codereview.chromium.org/248029 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@28155 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Sep, 2009 1 commit
-
-
thakis@chromium.org authored
Original review url: http://codereview.chromium.org/225007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26928 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 Sep, 2009 1 commit
-
-
yaar@chromium.org authored
and append them to the patch sent to the try bots. This is very useful for chromium+webkit tries. Review URL: http://codereview.chromium.org/212034 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26817 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Sep, 2009 1 commit
-
-
johnnyg@chromium.org authored
Review URL: http://codereview.chromium.org/213004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26452 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Sep, 2009 1 commit
-
-
chase@chromium.org authored
TBR=maruel Review URL: http://codereview.chromium.org/177047 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@24994 0039d316-1c4b-4281-b951-d872f2087c98
-
- 29 Aug, 2009 1 commit
-
-
mattm@chromium.org authored
Review URL: http://codereview.chromium.org/173446 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@24848 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 Aug, 2009 1 commit
-
-
chase@chromium.org authored
Make git-try use trychange for both SVN and HTTP try server submits. Simplifies git-try and reduces chance of differences in behavior between SVN and HTTP try job submits. Exit early if the checkout's configured email address does not pass validation. Simplify trychange import. BUG=none TEST=git-try submits a job to the try server Review URL: http://codereview.chromium.org/173394 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@24315 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 Aug, 2009 2 commits
-
-
chase@chromium.org authored
TBR=maruel BUG=none TEST=none Review URL: http://codereview.chromium.org/173249 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@24064 0039d316-1c4b-4281-b951-d872f2087c98
-
chase@chromium.org authored
BUG=none TEST=none TBR=maruel Review URL: http://codereview.chromium.org/173246 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@24060 0039d316-1c4b-4281-b951-d872f2087c98
-
- 04 Aug, 2009 1 commit
-
-
maruel@chromium.org authored
Add .gitignore for causual ignores. TEST=none BUG=none Review URL: http://codereview.chromium.org/159855 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@22380 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Jun, 2009 1 commit
-
-
maruel@chromium.org authored
Otherwise, all the parameters are coagulated into a single one. TEST=none BUG=none Review URL: http://codereview.chromium.org/119308 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17968 0039d316-1c4b-4281-b951-d872f2087c98
-
- 05 Jun, 2009 1 commit
-
-
maruel@chromium.org authored
They automatically git clone the original repository and execute the original script. So if they are first in the path, they will be executed. If a user has another git-cl/try in the path prior, these stubs won't be used at all and won't mess with the user's setup. Also fix a bug with git handling in trychange.py Review URL: http://codereview.chromium.org/119244 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17737 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 May, 2009 1 commit
-
-
maruel@chromium.org authored
Review URL: http://codereview.chromium.org/113205 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15757 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Apr, 2009 1 commit
-
-
maruel@google.com authored
Review URL: http://codereview.chromium.org/92087 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@14349 0039d316-1c4b-4281-b951-d872f2087c98
-