- 18 Apr, 2017 3 commits
-
-
Aaron Gable authored
Gerrit sometimes returns a full response json object at the same time as returning a non-200 status code. This refactor makes it easier for calling code to request access to that object and handle error cases on its own. The original version of this commit had a bug where ReadHttpResponse properly set the default value for accept_statuses, but all calls which came through ReadHttpJsonResponse were setting None instead. Bug: 710028 Change-Id: I8cee435d8acd487fb777b3fd69b5e48e19d2e5a3 Reviewed-on: https://chromium-review.googlesource.com/481060Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
Aaron Gable authored
This reverts commit 6d7ab1bf. Reason for revert: Stacktrace: File "/s/depot_tools/gerrit_util.py", line 816, in GetAccountDetails return ReadHttpJsonResponse(conn) File "/s/depot_tools/gerrit_util.py", line 376, in ReadHttpJsonResponse fh = ReadHttpResponse(conn, accept_statuses) File "/s/depot_tools/gerrit_util.py", line 365, in ReadHttpResponse if response.status not in accept_statuses: TypeError: argument of type 'NoneType' is not iterable Original change's description: > Refactor ReadHttpResponse to be error-friendlier > > Gerrit sometimes returns a full response json object at > the same time as returning a non-200 status code. This > refactor makes it easier for calling code to request > access to that object and handle error cases on its own. > > Bug: 710028 > Change-Id: Id1017d580d2fb843d5ca6287efcfed8775c52cd6 > Reviewed-on: https://chromium-review.googlesource.com/479450 > Commit-Queue: Aaron Gable <agable@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > TBR=agable@chromium.org,tandrii@chromium.org,chromium-reviews@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Ia9d9ce835e207a32e7cc8ee35c0cf40c823c7b78 Reviewed-on: https://chromium-review.googlesource.com/481059Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
Aaron Gable authored
Gerrit sometimes returns a full response json object at the same time as returning a non-200 status code. This refactor makes it easier for calling code to request access to that object and handle error cases on its own. Bug: 710028 Change-Id: Id1017d580d2fb843d5ca6287efcfed8775c52cd6 Reviewed-on: https://chromium-review.googlesource.com/479450 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
- 16 Dec, 2016 1 commit
-
-
Quinten Yearsley authored
This affects a bunch of files, but only changes comments, and shouldn't make any difference to behavior. The purpose is to slightly improve readability of pylint disable comments. Change-Id: Ic6cd0f8de792b31d91c6125f6da2616450b30f11 Reviewed-on: https://chromium-review.googlesource.com/420412Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
-
- 17 Jun, 2016 1 commit
-
-
mgiuca authored
Review-Url: https://codereview.chromium.org/2075923003
-
- 16 Jun, 2016 1 commit
-
-
vapier authored
Review-Url: https://codereview.chromium.org/2076613002
-
- 17 Oct, 2013 1 commit
-
-
szager@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/27756002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@229216 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Oct, 2013 1 commit
-
-
szager@chromium.org authored
gob_util.py is a general-purpose library for communicating with the gerrit-on-borg service. testing_support/gerrit_test_case.py is a unittest framework for testing code that interacts with gerrit. R=vadimsh@chromium.org, cmp@chromium.org BUG= Review URL: https://codereview.chromium.org/26399002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@228965 0039d316-1c4b-4281-b951-d872f2087c98
-