- 18 Sep, 2018 6 commits
-
-
Vadim Shtayura authored
Together with already committed cipd_client_version.digests file, this cryptographically binds contents of CIPD packages used by depot_tools with depot_tool's git revision (assuming the CIPD client pinned by cipd_client_version.digests is trusted too, which can presumably be verified when it is being pinned). This holds true even if the CIPD backend is compromised. The worst that can happen is a denial of service (e.g. if the backend refuses to serve packages at all). If a bad backend tries to serve a malicious (unexpected) CIPD client, 'cipd' bootstrap script (and its powershell counterpart) will detect a mismatch between SHA256 of the fetched binary and what's specified in cipd_client_version.digests, and will refuse to run the untrusted binary. Similarly, if the bad backend tries to serve some other unexpected package (in place of a package specified in cipd_manifest.txt), the CIPD client (already verified and trusted as this point) will detect a mismatch between what was fetched and what's pinned in cipd_manifest.versions, and will refuse to install untrusted files. cipd_manifest.versions was generated from cipd_manifest.txt by: $ cipd ensure-file-resolve -ensure-file cipd_manifest.txt This will have to be rerun each time cipd_manifest.txt is updated. There's a presubmit check that verifies *.versions file is up-to-date (it's part of 'cipd ensure-file-verify'). BUG=870166 R=nodir@chromium.org, iannucci@chromium.org, tandrii@chromium.org Change-Id: I25314adf0a9b05c69cd16e75aff01dbc79c87aa5 Reviewed-on: https://chromium-review.googlesource.com/1227435 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
Eric Boren authored
This reverts commit 18b4479c. Reason for revert: Breaking WebRTC roller: https://luci-milo.appspot.com/buildbot/client.webrtc.fyi/Auto-roll%20-%20WebRTC%20DEPS/12788 Original change's description: > gerrit_util: Support OAuth2 bearer tokens in CookieAuthenticator > > Change-Id: I9fd3e2fa9ea16d7f057290e77a81f7009c7c9d91 > Reviewed-on: https://chromium-review.googlesource.com/1221826 > Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > Commit-Queue: Eric Boren <borenet@chromium.org> TBR=vadimsh@chromium.org,dnj@chromium.org,borenet@chromium.org,tandrii@chromium.org Change-Id: I93bbd2d09cd2b27d9a7aa98fc15d60c5033a38cd No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1231433Reviewed-by: Eric Boren <borenet@chromium.org> Commit-Queue: Eric Boren <borenet@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/f7a834467c55fc302e5da1bdc0ef78c7bdecf2d9 Add comment to failing_step to indicate that it raises an exception. (erikchen@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9b3ab8e2145e52711a7a725d6af77afb93f8ad0b Reviewed-on: https://chromium-review.googlesource.com/1230793 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
Michael Achenbach authored
V8 uses buildbucket.py to trigger flake-bisect jobs on command line. It's more convenient if the build url is shown. Bug: 711249 Change-Id: I5737c6f3fd72b60517662e8a4808186d6acc71db Reviewed-on: https://chromium-review.googlesource.com/1226912 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> Reviewed-by: smut <smut@google.com>
-
Eric Boren authored
Change-Id: I9fd3e2fa9ea16d7f057290e77a81f7009c7c9d91 Reviewed-on: https://chromium-review.googlesource.com/1221826Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Eric Boren <borenet@chromium.org>
-
Vadim Shtayura authored
The new version uses SHA256 for uploads by default. It also fully supports $ResolvedVersions and 'selfupdate-roll'. The roll was generated by: $ ./cipd selfupdate-roll \ -version-file cipd_client_version \ -version git_revision:fb963f0f43e265a65fb7f1f202e17ea23e947063 BUG=821194, 870166 R=nodir@chromium.org, iannucci@chromium.org Change-Id: If7c23c43ff2c1bf50c9c50f4e9e17a23e84859b9 Reviewed-on: https://chromium-review.googlesource.com/1227431 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
-
- 17 Sep, 2018 3 commits
-
-
Andrii Shyshkalov authored
R=ajp@chromium.org Bug: 881860 Change-Id: I2a5fc981fce05664ea077cad74458bc38c37f1e7 Reviewed-on: https://chromium-review.googlesource.com/1227439 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
-
Leszek Swirski authored
Print "git cl comments" json to stdout when the output file is "-" Change-Id: I91021317e52019a0d499cccc4f40f062127b300e Reviewed-on: https://chromium-review.googlesource.com/1228094 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
-
Andrii Shyshkalov authored
Test: verified the same reviews list is produced w/o and w/ this change. Change-Id: I72be85734a84d96a06b74515e64344fc203b1eed Reviewed-on: https://chromium-review.googlesource.com/1227442Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
- 14 Sep, 2018 3 commits
-
-
Vadim Shtayura authored
Not enabling it yet, since PRESUBMIT.py uses presubmit_canned_checks.py from depot_tools at HEAD, not from a CL (thus enabling this check in this CL will make it fail the presubmit). R=nodir@chromium.org BUG=870166 Change-Id: I97802ec37f1f7513dfca3950f7f38a5c51ab0350 Reviewed-on: https://chromium-review.googlesource.com/1227432Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
-
Vadim Shtayura authored
Errors during the download should be reported as such, not as "failed to grab the lock file". R=nodir@chromium.org, iannucci@chromium.org BUG=853722 Change-Id: If24f4587693852eed0608450bcd311cf3bafd2c3 Reviewed-on: https://chromium-review.googlesource.com/1226106Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/b8db432be1add133ef005e17d5729c537349f2c9 analyze.py: Actually include default fields (martiniss@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I8ed2a785a4e25d4c93c1b1c32ea1489ee717d112 Reviewed-on: https://chromium-review.googlesource.com/1226231Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
- 13 Sep, 2018 6 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/241d879a3dee0f9f1a0dc8933dc67f24e0d33391 analyze: Output field default values (martiniss@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Iefc3478b7e8857a23830a2d0788d3b3e45b1816b Reviewed-on: https://chromium-review.googlesource.com/1226230 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/04e26b62818d4848aed3631d9c58c2d41ecc2ed8 [buildbucket] Pass v2 build as a dict, not base64 bytes (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I756d39fb0004d220d4113ef56fffa3065674b32e Reviewed-on: https://chromium-review.googlesource.com/1225671Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/1f3949c4d11c89d35d1e4c688c3a1c14985bdad7 [file] Fix naming conflict bug in flatten_single_directories. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ib2ff5f1c89486ff05e4e5fba1d29e63d0fed7761 Reviewed-on: https://chromium-review.googlesource.com/1225670Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/5831fa01c47fb7248495566e80d4d049c47d3f78 Fix config.Dict.schema_proto. (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I708632280df12d762cc6e3fbcfdef327e2bf5ef1 Reviewed-on: https://chromium-review.googlesource.com/1225390Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Steve Kobes authored
Bug: 881860 Change-Id: I6402ff2665b70b46558799dbb16ac9c7a9d7d640 Reviewed-on: https://chromium-review.googlesource.com/1224990Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org>
-
Robert Iannucci authored
R=hinoka@chromium.org, nodir@chromium.org, tandrii@chromium.org Bug: 875089 Change-Id: I6abb7a5d0aebf53c4c3ab6be309ed43e652278c0 Reviewed-on: https://chromium-review.googlesource.com/1222883 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Ryan Tseng <hinoka@chromium.org>
-
- 11 Sep, 2018 3 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/ed19633e4183c8304db2a9bfd8646819c68ba5ba [tricium] Write tricium output as a string (juliehockett@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I8b14edc9a1a6c1a8eea61ab5573a8fa4a0cf1bf0 Reviewed-on: https://chromium-review.googlesource.com/1220109Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Nodir Turakulov authored
Add tryserver.api.gerrit_change_info that returns detailed info about the current Gerrit CL. It makes a Gerrit RPC in the background on the first read. This step will be present in all tryjobs. This mechanism can be used for extra details about the current CL. This CL starts to use this in bot_update for gerrit_ref, and stops using patch_ref property, and also update bot_update to use when the destination branch is needed. Also this CL removes no longer used properties in bot_update, namely most of patch_* properties. build.git manual roll: https://chromium-review.googlesource.com/c/chromium/tools/build/+/1217626 Recipe-Manual-Change: build Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: skia Recipe-Nontrivial-Roll: skiabuildbot Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: release_scripts R=tandrii@chromium.org Bug: 694348 Change-Id: I945d061b74278c3d1d227578abe16a64cdaca647 Reviewed-on: https://chromium-review.googlesource.com/1213557 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/fc3791701f0801ab86e840225a7a566fee806ba0 [buildbucket] add revision param to try_build (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I01d776eaf2db235ddb8875ae68a84f17dfdd3b75 Reviewed-on: https://chromium-review.googlesource.com/1217693Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
- 10 Sep, 2018 7 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/35df4133e3d4282971f11b531c2e247c8644be81 [buildbucket] Remove gerrit_host param (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I2cbe0fe2f514719f6d419f55110302cd8105ca53 Reviewed-on: https://chromium-review.googlesource.com/1217687Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/e7c361bd4185326e511520b11950cab5d4291281 time module: Make sleep shell out sometimes (martiniss@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ie6caee3f0811a3fded54338f3baf0a2685d42f7a Reviewed-on: https://chromium-review.googlesource.com/1217684Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Nodir Turakulov authored
CrOS chromium-pfq builder uses bot_update, but checks out Chromium on its own, effectively ignoring input commit in bot_update. To resolve a P0, add ignore_input_commit parameter. Long term, bot_update API must be redesigned. TBR=tandrii@chromium.org Bug: 882094 Change-Id: I4f43348e3d5f81bf603dd2c110829bce58acad16 Reviewed-on: https://chromium-review.googlesource.com/1216787Reviewed-by: Lann Martin <lannm@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
-
Nodir Turakulov authored
This is a reland of 4d2b9018 verbatim. The problem was in the buildbucket recipe module, see https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1215002#message-2351f1089af71655dbaff576aa4d11f1dedc800b Original change's description: > [bot_update] Stop using repository properties > > Stop using repository and patch_repository_url properties. > Use self.m.buildbucket.build.input.gerrit_changes[0].{host, project} > instead. > > R=ehmaldonado@chromium.org, tandrii@chromium.org > > Recipe-Nontrivial-Roll: build > Bug: 877161, 694348 > Change-Id: Ideb069c6c8f8b6e6cfb5217f8a04ea18f16d3056 > Reviewed-on: https://chromium-review.googlesource.com/1208368 > Commit-Queue: Nodir Turakulov <nodir@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: skia Bug: 877161, 694348 Change-Id: I0a10ca7814a8f5bdfd30a491e36fb7261cdaf225 Reviewed-on: https://chromium-review.googlesource.com/1214705Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/596d92ee90439a73ae92c66bd25d9ec27e43b1a7 [buildbucket] Prefer patch_* properties (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Iaba289c2e1ddfb3de29364b82e44a184978940bb Reviewed-on: https://chromium-review.googlesource.com/1217203Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Corentin Wallez authored
When a recursive dependency has use_relative_paths it also makes sense to have the hooks working directory by the dependency's directory. Otherwise if a hook uses one of the relative dependencies it is impossible to know which path prefix to use. However we cannot change the behavior of hooks with use_relative_paths because it would break existing projects that use_relative_paths but hardcoded the prefix for hooks. Instead we add a second boolean, use_relative_hooks that triggers the behavior. Adds tests for the new behavior and a test for existing interactio between hooks and recursedeps. BUG=chromium:875245 Change-Id: Ie4c526baa425ff887b3be54e0feca7c597ededec Reviewed-on: https://chromium-review.googlesource.com/1213327 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/bf667d884ccd1a8b83a757b60e4fe1f98e7c48a5 [cipd] Expose additional pkg-def options through recipe module (phosek@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Idcbc24cf099f8f0a3494c7401abe4a9db07df2bd Reviewed-on: https://chromium-review.googlesource.com/1214487 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
- 09 Sep, 2018 1 commit
-
-
Kenneth Russell authored
For some users who have a long history on the issue tracker, Monorail queries were timing out with the default timeout. Bug: 882266 Change-Id: Ib458f129d5a5f0eb04e035c016957730a1be1b99 Reviewed-on: https://chromium-review.googlesource.com/1214707 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
- 08 Sep, 2018 2 commits
-
-
Nodir Turakulov authored
This reverts commit 4d2b9018. Reason for revert: https://chromium-review.googlesource.com/c/chromium/tools/build/+/1214622 Original change's description: > [bot_update] Stop using repository properties > > Stop using repository and patch_repository_url properties. > Use self.m.buildbucket.build.input.gerrit_changes[0].{host, project} > instead. > > R=ehmaldonado@chromium.org, tandrii@chromium.org > > Recipe-Nontrivial-Roll: build > Bug: 877161, 694348 > Change-Id: Ideb069c6c8f8b6e6cfb5217f8a04ea18f16d3056 > Reviewed-on: https://chromium-review.googlesource.com/1208368 > Commit-Queue: Nodir Turakulov <nodir@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> TBR=nodir@chromium.org,tandrii@chromium.org,ehmaldonado@chromium.org Change-Id: I825242124382e9f1789d4a3da0a3bdd2a5fcab37 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 877161, 694348 Reviewed-on: https://chromium-review.googlesource.com/1214703Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
-
Nodir Turakulov authored
Stop using repository and patch_repository_url properties. Use self.m.buildbucket.build.input.gerrit_changes[0].{host, project} instead. R=ehmaldonado@chromium.org, tandrii@chromium.org Recipe-Nontrivial-Roll: build Bug: 877161, 694348 Change-Id: Ideb069c6c8f8b6e6cfb5217f8a04ea18f16d3056 Reviewed-on: https://chromium-review.googlesource.com/1208368 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
- 07 Sep, 2018 9 commits
-
-
Corentin Wallez authored
BUG= Change-Id: I1f8be18b821d45564bbabbd4e90eb2624d51a3f9 Reviewed-on: https://chromium-review.googlesource.com/1213582Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
-
Andrii Shyshkalov authored
He's been doing great work in depot_tools over last year, and has sufficient knowledge to know when to review and when to find better reviewers for this repo. R=ehmaldonado@chromium.org Change-Id: Idc8c9103906b9a48b69c4a2743e344d0886a759d Reviewed-on: https://chromium-review.googlesource.com/1213589Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Stephen Martinis authored
Bug: 878117 Change-Id: Ifb8af6bfcc6467ad9b79cf6292ebb8afc8f7e949 Reviewed-on: https://chromium-review.googlesource.com/1213588Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Ryan Tseng <hinoka@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
-
Corentin Wallez authored
BUG= Change-Id: I7561d252e10ae9b376e1b61ea3846cc8fc08f472 Reviewed-on: https://chromium-review.googlesource.com/1213323Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
-
Nodir Turakulov authored
Pass git_repo param when calling buildbucket.test_api.try_build. TBR=hinoka@chromium.org Change-Id: Ic4a3d270ef3477cb21e4e02d8a22caf7996757b3 Reviewed-on: https://chromium-review.googlesource.com/1213555Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
-
Nodir Turakulov authored
tryserver module's purpose is to provide high level API for patches. Update it to use buildbucket.build.input.gerrit_changes[0]. Add helper properties for gerrit repo URL and gerrit ref. This will be used by both bot_update and gclient. R=hinoka@chromium.org, tandrii@chromium.org Bug: 694348 Change-Id: I7eb416e75737310404c4354fa680fd3499eddaa7 Reviewed-on: https://chromium-review.googlesource.com/1211653 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Ryan Tseng <hinoka@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/25a327e765e0410f2dcaf152db9cdaba73207182 [buildbucket] Add git_repo to test_api.try_build (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I73c5a786121b8135f9a6d373daf7b71e71b1c4d7 Reviewed-on: https://chromium-review.googlesource.com/1213982 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/6116e44efc754249e8d5f1d9cdbf21f766ca781a [buildbucket] Populate gerrit project in tests (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9b2046c0e1ae281f328119b5aa28a2b15e83c170 Reviewed-on: https://chromium-review.googlesource.com/1212163 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/19f53cfa422c6b4aed11a29c415f801051e2bac5 Add the analyze command (martiniss@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I3d7b0bf3003ecd179440d3b70ec2a5d247ac3e53 Reviewed-on: https://chromium-review.googlesource.com/1212162Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-