Commits · 016a0876eaa409609352e145ec61f92f22ff7056 · Linshizhi / Chromium_Depot_tools

04 Feb, 2020 4 commits

presubmit_support: Pass a gerrit object instead of a cl object to PostUploadHook. · 016a0876

Edward Lemur authored Feb 04, 2020

Pass a gerrit object instead of a git-cl ChangeList object to
PostUploadHook to remove dependency of presubmit_support in git-cl.

Requires https://skia-review.googlesource.com/c/skia/+/265209

Bug: 1042324
Change-Id: I4b20b75deb6a3d8d4caf46ca3580883699dbf707
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2008287
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

016a0876

presubmit_support: Add --all-files options. · 1c8026d2

Edward Lemur authored Feb 04, 2020

Will be set when --all is passed to git-cl presubmit to execute
presubmit checks over all files on a repo.

Bug: 1042324
Change-Id: I2ebb7c3ec633f9d3a3774314799aa056bc2919c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2003071Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

1c8026d2

Roll recipe dependencies (trivial). · 1c6a8d32

recipe-roller authored Feb 04, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/f72daca5c12eb4d83d74c25465520380c169c6b2 (maruel@google.com)
    [swarming] Always trim output when raising an exception

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id6c7d59126fda025b50654148c7c8781674358fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2037870Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

1c6a8d32

Also set LIBPATH in Windows toolchain environment · e9310189

Yuly Novikov authored Feb 04, 2020

Needed to find *.winmd files for UWP build.

This CL and crrev.com/c/2007881 were used to generate the recent
toolchains with UWP support:
b92fff97f2e0323e99803f37f4b77b843bdbf69d in crrev.com/c/2015984 and
9ff60e43ba91947baca460d0ca3b1b980c3a2c23 in crrev.com/c/2025528.

Bug: chromium:1032635
Change-Id: I1ab0b6e11a30600deb377078815c268d8f9027e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2013579
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>

e9310189

03 Feb, 2020 4 commits

presubmit_unittest: Mock time_time for ThreadPoolTest · d7c06ac6

Edward Lemur authored Feb 03, 2020

Mock time_time so that time.time is not called from ThreadPoolTest tests,
so that the execution time doesn't change between executions.

Bug: 1047631
Change-Id: I4f4ac30ca6a2ee3be25830c0e17a9f29a9c0c999
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2036477Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

d7c06ac6

presubmit_support: Add support for setting the change description. · e4d329cc

Edward Lemur authored Feb 03, 2020

Needed by Skia's PostUploadHooks, so that presubmit_support
doesn't depend on git-cl classes.

Bug: 1042324
Change-Id: I02475e346437b26fa8d0d2021ea62754077a2b5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2007262Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

e4d329cc

presubmit_support: Support getting and adding footers. · 69bb8bef

Edward Lemur authored Feb 03, 2020

Needed by Skia's PostUploadHooks, so that presubmit_support doesn't
depend on git-cl internal classes.

Bug: 1042324
Change-Id: If8f4e6ea035197667cd9705a4274590c4d11511e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2007670Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

69bb8bef

Don't drop windows.winmd when packaging Windows toolchain · 852d4aa1

Yuly Novikov authored Feb 03, 2020

It is needed for UWP build and is the same on at least 2 machines in
C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.18362.0\Windows.winmd

Bug: chromium:1032635
Change-Id: I9d7148a8dc11ea85f1b930f63ae19eaa58ac2bf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2007881Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

852d4aa1

31 Jan, 2020 5 commits

Use logger where unit test has coverage · 906bfde9

Josip authored Jan 31, 2020

Change-Id: I0a4d16fef3aed6bba0c6015fe861a2f11558e11b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2029114
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Anthony Polito <apolito@google.com>

906bfde9

Enable Javascript formatting by default · 42a51f6a

Tim van der Lippe authored Jan 31, 2020

This removes the need for explicitly passing `--js` to `git cl format`
to format both JavaScript and TypeScript. It would reduce a significant
amount of mental overhead for formatting code in DevTools frontend,
which is primarily JS/TS.

Fixed: 1007347
Change-Id: Ia35c9af677d12ce9be72fe5fcdd6ceb6cb039c5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2029371Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>

42a51f6a

Enable recipe-roller autosubmit · 4d678727

Aaron Gable authored Jan 31, 2020

Bug: 773529
Change-Id: If00fae56890e7826f9a08ccafe7d45fff2d31ed0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2015615
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Auto-Submit: Aaron Gable <agable@chromium.org>

4d678727

[roll] Fix the command in the commit message · 4ada8ab4

Sylvain Defresne authored Jan 31, 2020

The CL https://crrev.com/c/chromium/tools/depot_tools/+/2031104 used
the full hash when calling "git log" to fix the roll on some bot. It
however resulted in the full hash visible in the commit message.

Fix the command included in the commit message while still using the
full hash in the command invoked.

Bug: none
Change-Id: I454e600fc34e554c1186ae9488ea4b0f7e7df310
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2031105
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>

4ada8ab4

Tentative fix for roll-dep.py failing in generate commit message · ae2b962c

Sylvain Defresne authored Jan 31, 2020

Some bots run roll-dep.py and fail while generating the commit message
with the following error:

  src/ios/third_party/material_components_ios/src: Rolling from 54fd1dac39 to 5aaf54801f
  fatal: ambiguous argument '54fd1dac3..5aaf54801': unknown revision or path not in the working tree.
  Use '--' to separate paths from revisions, like this:
  'git <command> [<revision>...] -- [<file>...]'

As "Rolling from 54fd1dac39 to 5aaf54801f" is printed, this mean that
the bot was able to resolve both HEAD and roll_to before invoking this
function, thus the corresponding hashes exists in the repository.

It is unlikely that shortening the hash to just the first nine chars
results in a collision, but there is no reason to use a short hash
when invoking git anyway, so use a separate variable to construct the
header of the commit with short hashes while invoking git with the
full hashes.

Also pass '--' after all the parameters to force git to interpret the
hash range as a range and not as a path.

This is a speculative fix.

Change-Id: Iaa2888610dcf8e20f9edc115a719791d573b83ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2031104Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>

ae2b962c

30 Jan, 2020 4 commits

Do not crash for non URL (i.e. SSH) remotes. · ae510e8f

Florian Mayer authored Jan 30, 2020

Without this change, having an SSH remote configured makes `git cl
archive` crash:

Traceback (most recent call last):
  File "/usr/local/google/home/fmayer/depot_tools/metrics.py", line 267, in print_notice_and_exit
    yield
  File "/usr/local/google/home/fmayer/depot_tools/git_cl.py", line 5553, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/usr/local/google/home/fmayer/depot_tools/git_cl.py", line 5535, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/usr/local/google/home/fmayer/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/usr/local/google/home/fmayer/depot_tools/metrics.py", line 252, in _inner
    return self._collect_metrics(func, command_name, *args, **kwargs)
  File "/usr/local/google/home/fmayer/depot_tools/metrics.py", line 232, in _collect_metrics
    gclient_utils.reraise(exception[0], exception[1], exception[2])
  File "/usr/local/google/home/fmayer/depot_tools/metrics.py", line 205, in _collect_metrics
    result = func(*args, **kwargs)
  File "/usr/local/google/home/fmayer/depot_tools/git_cl.py", line 3786, in CMDarchive
    for cl, status in statuses
  File "/usr/local/google/home/fmayer/depot_tools/git_cl.py", line 3599, in get_cl_statuses
    cl.EnsureAuthenticated(force=False, refresh=True)
  File "/usr/local/google/home/fmayer/depot_tools/git_cl.py", line 1757, in EnsureAuthenticated
    if urllib.parse.urlparse(self.GetRemoteUrl()).scheme != 'https':
  File "/usr/lib/python2.7/urlparse.py", line 143, in urlparse
    tuple = urlsplit(url, scheme, allow_fragments)
  File "/usr/lib/python2.7/urlparse.py", line 201, in urlsplit
    i = url.find(':')
AttributeError: 'NoneType' object has no attribute 'find'

Change-Id: I6f794f11d3ed5e3dbedfe278ded660fca32abda6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2030505
Commit-Queue: Florian Mayer <fmayer@google.com>
Reviewed-by: Anthony Polito <apolito@google.com>

ae510e8f

Roll recipe dependencies (trivial). · 305542ea

recipe-roller authored Jan 30, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/5a91e29d366be1e9e7c7e270a1da92790625c618 (tikuta@chromium.org)
swarming: remove deprecated arg

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I14bbc2e7281a0a29ae21e110b6e5a730307aec00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2029118Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

305542ea

Roll recipe dependencies (trivial). · 29e5a1af

recipe-roller authored Jan 30, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/7d4ed3e64183a01cba0ef7abfa6ca1a4e586cef7 (tikuta@chromium.org)
swarming: update swarming client

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7f1620f22238a3ea6c27dc4066c1e722d3b138bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2029116Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

29e5a1af

Adds support to edit description on git cl upload · e827b0f7

Josip authored Jan 30, 2020

git cl upload gets a new flag --edit-description, which allows user to
edit git commit message. It only works when updating existing CL.

Bug: 739928
Change-Id: Ia501dc31f32e1887a937d5df39aed03745376827
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2020591Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

e827b0f7

29 Jan, 2020 1 commit

Let the presubmit recipe module skip owners checks when necessary · 1a0daf72

Aaron Gable authored Jan 29, 2020

The circumstances under which this might happen are left up to the
invoking recipe, which in most cases is the chromium presubmit.py.

Bug: 1034114
Change-Id: Ia8db6ab0da04750d6753e6281ef859e19aea4039
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2018224
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>

1a0daf72

28 Jan, 2020 2 commits

add apolito to owners · ea8b58b9

Anthony Polito authored Jan 28, 2020

Change-Id: I70191146494462302cdef5835f1c3c690a201b5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2025728Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Anthony Polito <apolito@google.com>

ea8b58b9

OWNERS: add ukai for cipd_manifest.* · 9d635962

Fumitoshi Ukai authored Jan 28, 2020

goma team will release goma client cipd in depot_tools,
by modifying cipd_manifest.txt and cipd_manifest.versions

add ukai as OWNERS so that goma cilent release won't need
to wait for review.

Change-Id: I7f49d9c07b23d18c4a05ab11bea855d3f557a6ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2024208
Auto-Submit: Fumitoshi Ukai <ukai@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

9d635962

27 Jan, 2020 3 commits

roll out new goma client binary (VERSION=188) · ca7b3bf3

Fumitoshi Ukai authored Jan 27, 2020

https://chromium.googlesource.com/infra/goma/client/+/6e253cdf85f7fe2714570ef66f4edda63c33c193

BUG=b/145258781

Change-Id: Ic5f0f4895cce83e258b88a38ec22189a8c7b80d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2022403
Auto-Submit: Fumitoshi Ukai <ukai@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>

ca7b3bf3

gclient: allow clients to pass deps_file name as config kwarg. · f437869d

John Budorick authored Jan 27, 2020

Bug: 1041701
Change-Id: I7c25d6b25eefc29f7a5e815d8664d5dfd2226cf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2019018Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

f437869d

Fix a python invocation that wasn't replaced with vpython. · 1248b8ef

Peter Kasting authored Jan 27, 2020

This fixes autoninja on my Windows machine at home.

Bug: none
Change-Id: I3c245715c409bb2b30fcc3733bb097fc2a88f464
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2021755Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>

1248b8ef

25 Jan, 2020 1 commit

presubmit: restore default 8-minute timeout. · 0aa48cc1

John Budorick authored Jan 25, 2020

This logic's predecessor, run_presubmit, used an 8-minute timeout in
all cases other than luci-py. Using that as a default (rather than 0s)
seems reasonable.

Recipe-Nontrivial-Roll: build
Change-Id: I4b8668531db1a243709979b580c5170c22a0729f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2020987
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

0aa48cc1

24 Jan, 2020 2 commits

add revision to scheduleBuild call for git cl try if needed. · 1a5fe235

Anthony Polito authored Jan 24, 2020

Bug: 1043877
Change-Id: I5363dc1ad7f6b7e0ce9ce9885c86e357c3c65339
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2016162Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Anthony Polito <apolito@google.com>

1a5fe235

[lucicfg] Update v1.11.17 -> v1.11.18 · bf4e7a72

Aaron Gable authored Jan 24, 2020

Changes:
  * Add cq group name to lucicfg graph (https://crrev.com/c/1986093)

Bug: 1035470
Change-Id: Iea5a57fdceadba45cb07bee8c13ba2cac1b62287
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2020583
Auto-Submit: Aaron Gable <agable@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

bf4e7a72

23 Jan, 2020 2 commits

Roll recipe dependencies (trivial). · 9403c3fc

recipe-roller authored Jan 23, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/6163c134a0320158e9c0778f9ee532a81d03e0ed (agable@chromium.org)
Remove recipe engine autoroller config

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9c45918675b2ae5647eed5531c4e53ea1bb4334b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2018226Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

9403c3fc

Improve git cl split · 68409634

Yannic Bonenberger authored Jan 23, 2020

This CL changes the behavior of `git cl split` to split the change
by the size of the resulting CLs. For now, this is based on the number
of bytes changed, and not by the number of changed lines. Depending
on the shape of change, this may still produce more CLs than expected
(and possibly more than before).

A future change will switch the split to be based on the number
of affected lines, and also introduce a mode to base the split
on the number of affected files.

Bug: 998922
Change-Id: I49f868972a61b89b426ef9e2ceedc733eacb4350
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1778744
Commit-Queue: Yannic Bonenberger <yannic.bonenberger@gmail.com>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

68409634

22 Jan, 2020 2 commits

Roll recipe dependencies (trivial). · bdd89366

recipe-roller authored Jan 22, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/d5f7fbd67a6fb31d0491b5ba3e7f4a46c6668a37 Add autosubmit to recipes.cfg nontrival roll options (agable@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0e8c91742a5c5a34af015e993076eff7db272e6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2013588Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

bdd89366

export PYTHONDONTWRITEBYTECODE instead of just defining constant · 6a5aa668

Gregory Nisbet authored Jan 22, 2020

BUG=chromium:1040314
TEST=shellcheck
Change-Id: I237df73daad84aeebfc934c9ddcc3eb632598827
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1995993Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Gregory Nisbet <gregorynisbet@google.com>

6a5aa668

21 Jan, 2020 2 commits

Roll recipe dependencies (trivial). · d339e366

recipe-roller authored Jan 21, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/4ca9794b2e5b9fc85fd080bf5c19fa2d0f22cc3d [resultdb] Wait for tasks to complete (nodir@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic165d5ee3d4ad2563df02473ccf457547dfc266c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2013219Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

d339e366

git cl: warn when landing on chromium/src branch-heads. · 8effa4d0

Andrii Shyshkalov authored Jan 21, 2020

Undos a hack added while CQ for branches was experimental.

R=ehmaldonado

Bug: 1043225, 753213
Change-Id: Ie88b61e61f59e828f0ac4a36cf4e356700305482
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2011308
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

8effa4d0

17 Jan, 2020 3 commits

presubmit_support: Initialize Gerrit object when gerrit URL is given. · b24ca5ac

Edward Lemur authored Jan 17, 2020

Only gerrit_url is needed to initialize gerrit_obj.
This will be needed for git cl to call presubmit support
as a script.

Bug: 1042324
Change-Id: I79d78fb67465f989755bf8c8ceb48d665464fa05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2005050Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

b24ca5ac

scm: Add GetAllFiles method. · 98cfac11

Edward Lemur authored Jan 17, 2020

Will be used by presubmit_support to run checks over all files on a repo.

Bug: 1042324
Change-Id: I872b4eb7f287f3a4b14d753cad73d0c5d7beb00c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2002961Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

98cfac11

presubmit_support: Use single quotes and convert to ArgumentParser. · a5799e3b

Edward Lemur authored Jan 17, 2020

Change-Id: I54f0fe3a2257166cba2a69659e5128e4ac9310bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2001707Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

a5799e3b

16 Jan, 2020 1 commit

Roll bb tool to @ 9b687fbe · 05b001c2

Andrii Shyshkalov authored Jan 16, 2020

Old revision: b7405423

Change logs:
  infra/infra:
    https://chromium.googlesource.com/infra/infra/+log/b7405423..9b687fbe
  luci-go
    https://chromium.googlesource.com/infra/luci/luci-go/+log/93937dc8..fa8b9bf0

Bug: 1041950
Change-Id: I79998caa77685240a61273d7f9a99b7fff2d0cd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2005468
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: LaMont Jones <lamontjones@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>

05b001c2

15 Jan, 2020 1 commit

subprocess2: Ensure environment keys and values are strings on Python 3 · e9730d75

Raul Tambre authored Jan 15, 2020

Example error during "git cl upload":
Traceback (most recent call last):
  File "C:\Google\depot_tools\presubmit_support.py", line 220, in CallCommand
    returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
  File "C:\Google\depot_tools\presubmit_support.py", line 204, in _RunWithTimeout
    p = subprocess.Popen(cmd, **kwargs)
  File "C:\Google\depot_tools\subprocess2.py", line 143, in __init__
    super(Popen, self).__init__(args, **kwargs)
  File "C:\Google\depot_tools\bootstrap-3_8_0b1_chromium_1_bin\python\bin\Lib\subprocess.py", line 390, in __init__
    errread, errwrite)
  File "C:\Google\depot_tools\bootstrap-3_8_0b1_chromium_1_bin\python\bin\Lib\subprocess.py", line 640, in _execute_child
    startupinfo)
TypeError: environment can only contain strings

Bug: 984182
Change-Id: Id996d73a80845aaeaa061107ed123627091cb600
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1815872
Commit-Queue: Raul Tambre <raul@tambre.ee>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Raul Tambre <raul@tambre.ee>

e9730d75

14 Jan, 2020 3 commits

my_activity: Make compatible with Python 3. · 2a048032

Edward Lemur authored Jan 14, 2020

Bug: 1009820
Change-Id: I2aa619eb1cc70f7cacd27cbc2afc5c04c3a77d1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2001224Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

2a048032

subcommand: Add tests. · 1c3b4bec

Edward Lemur authored Jan 14, 2020

Change-Id: I730f364f30b0d211c2db6da0d6bb4f5ff3c948da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1999280Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

1c3b4bec

[lucicfg] Update v1.11.14 => v1.11.17. · ce09ca54

Vadim Shtayura authored Jan 14, 2020

Changes:
  * luci.notifier_template(...) validates its name.
  * time.epoch(...) functions to parse timestamp strings into Unix times.
  * Internal digests.star module to calculate SHA256s.

R=iannucci@chromium.org

Change-Id: I58a3d9e11a2b278a0fd1e74169d6c57e048488f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2000986
Auto-Submit: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

ce09ca54