Skip to content

C
Chromium_Depot_tools
Switch branch/tag
  1. 17 Apr, 2020 1 commit
  3. 13 Mar, 2020 1 commit
  5. 11 Oct, 2019 1 commit
  7. 27 Sep, 2019 2 commits
  9. 24 Sep, 2019 2 commits
  11. 12 Aug, 2019 2 commits
  13. 06 Aug, 2019 2 commits
  15. 25 Jul, 2019 2 commits
  17. 16 Jul, 2019 1 commit
    • Raul Tambre's avatar
      fetch: Decode gclient output if returning stdout · 43271f94
      Raul Tambre authored 
      In Python 3 the output of a subprocess is bytes, so they need to be decoded to be used as a string.

This previously caused the following error if there was an existing checkout during a fetch:
Traceback (most recent call last):
  File "C:\Google\depot_tools\\fetch.py", line 318, in <module>
    sys.exit(main())
  File "C:\Google\depot_tools\\fetch.py", line 313, in main
    return run(options, spec, root)
  File "C:\Google\depot_tools\\fetch.py", line 299, in run
    if not options.force and checkout.exists():
  File "C:\Google\depot_tools\\fetch.py", line 98, in exists
    return (os.path.exists(os.path.join(gclient_root, b'.gclient')) or
  File "C:\Program Files\Python38\lib\ntpath.py", line 109, in join
    genericpath._check_arg_types('join', path, *paths)
  File "C:\Program Files\Python38\lib\genericpath.py", line 151, in _check_arg_types
    raise TypeError("Can't mix strings and bytes in path components") from None
TypeError: Can't mix strings and bytes in path components

Bug: 939847
Change-Id: Ibf5b4923268595ba439586d688894f92696ecbb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1701403
Auto-Submit: Raul Tambre <raul@tambre.ee>
Reviewed-by: 's avatarDirk Pranke <dpranke@chromium.org>
Commit-Queue: Raul Tambre <raul@tambre.ee>
      43271f94
  19. 18 Apr, 2019 1 commit
    • Elly Fong-Jones's avatar
      depot_tools: bail out if $PATH contains tildes · 7b294392
      Elly Fong-Jones authored 
      Bash and its descendants allow having $PATH entries containing literal tildes,
like:
  ...:~/depot_tools:...
If the user has their shell configured this way, their shell will be able to
invoke `fetch` and other depot_tools commands, but depot_tools will not in turn
be able to invoke subcommands via popen because popen does not have this
bash-specific behavior when not in shell mode.

This change has gclient detect this configuration problem and error out with a
descriptive error message. Not doing so leads to a puzzling condition where
gclient complains about being unable to find a program that (from the user's
perspective) is in their $PATH and invokable interactively.

It also has 'fetch' suppress its own failure stack trace if it runs gclient and
gclient fails; the 'fetch' stack trace pushes the messages from gclient (which
are actually diagnostic) off the screen.

Bug: chromium:952865
Change-Id: Ibba4d2fccee405aa68392ce141493f1de21ec018
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1573204
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: 's avatarAaron Gable <agable@chromium.org>
      7b294392
  21. 19 Mar, 2019 1 commit
  23. 09 Feb, 2018 1 commit
    • Torne (Richard Coles)'s avatar
      Don't fetch tags when using --no-history. · 08ca04b2
      Torne (Richard Coles) authored 
      After the initial gclient sync, "fetch --no-history" was adding a
fetchspec to the config for the main repository that causes all tags to
be downloaded in future. This means that after fetching a repository
with no history, the very next git pull (or other remote update
operation) will download all the tags, including all the history
referred to by those tags, leaving you with an almost-complete checkout
of the top-level repository that takes up much more space.

Fix this by skipping the "git config" command that requests the tags
when using no-history.

Change-Id: Ia31baa6a90df014ebc1e8c2ed6e05de3ad27d415
Reviewed-on: https://chromium-review.googlesource.com/909653Reviewed-by: 's avatarAaron Gable <agable@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
      08ca04b2
  25. 29 Jan, 2018 1 commit
  27. 29 Nov, 2017 1 commit
  29. 12 Jul, 2017 1 commit
    • Dan Jacques's avatar
      [git] Remove hard-coded "depot_tools" Git. · 209a681f
      Dan Jacques authored 
      Several tools, including the "git" recipe module, hard-code a
checkout-relative "git.bat" path. Git is a feature that is provided by
the system, both to tooling and recipes:

1) For users, "depot_tools" must be on PATH, and during setup it will
   have installed "git.bat", ensuring that Git tooling is available in
   PATH.
2) For bots, the system is responsible for providing "git.bat" on PATH.
   This is typically done at "/b/depot_tools/git.bat", which is sync'd
   through the "update_scripts" step.

By formally treating Git as a system resource, we absolve Windows bots
and users from manually installing a depot_tools-local Git, bringing
them in line with other platforms.

BUG=chromium:590806
TEST=local

Change-Id: I93e89855cdd330a2ba7a8cfb8117a1789d1ab54e
Reviewed-on: https://chromium-review.googlesource.com/568694
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
      209a681f
  31. 16 Dec, 2016 1 commit
  33. 26 Sep, 2016 1 commit
  35. 22 Sep, 2016 1 commit
  37. 09 May, 2016 1 commit
  39. 04 Dec, 2015 1 commit
  41. 19 Sep, 2015 1 commit
  43. 17 Jun, 2015 1 commit
  45. 15 Jun, 2015 2 commits
  47. 10 Jun, 2015 1 commit
  49. 26 Feb, 2015 1 commit
  51. 25 Nov, 2014 1 commit
  53. 22 Oct, 2014 1 commit
  55. 06 Aug, 2014 2 commits
  57. 05 Aug, 2014 2 commits
  59. 06 May, 2014 1 commit
  61. 03 Apr, 2014 1 commit
  63. 18 Mar, 2014 1 commit