Commit f5569d26 authored by Andrii Shyshkalov's avatar Andrii Shyshkalov Committed by Commit Bot

git cl: start deleting Rietveld support.

R=ehmaldonado

Bug: 770408
Change-Id: I5020596ada0c6fef2797fed6b78e7256a35ffc40
Reviewed-on: https://chromium-review.googlesource.com/c/1279131
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: 's avatarEdward Lesmes <ehmaldonado@chromium.org>
parent ba7b0a46
...@@ -1040,7 +1040,7 @@ class _ParsedIssueNumberArgument(object): ...@@ -1040,7 +1040,7 @@ class _ParsedIssueNumberArgument(object):
self.issue = issue self.issue = issue
self.patchset = patchset self.patchset = patchset
self.hostname = hostname self.hostname = hostname
assert codereview in (None, 'rietveld', 'gerrit') assert codereview in (None, 'gerrit', 'rietveld')
self.codereview = codereview self.codereview = codereview
@property @property
...@@ -1078,11 +1078,7 @@ def ParseIssueNumberArgument(arg, codereview=None): ...@@ -1078,11 +1078,7 @@ def ParseIssueNumberArgument(arg, codereview=None):
if len(results) == 1: if len(results) == 1:
return results.values()[0] return results.values()[0]
if parsed_url.netloc and parsed_url.netloc.split('.')[0].endswith('-review'): return results['gerrit']
# This is likely Gerrit.
return results['gerrit']
# Choose Rietveld as before if URL can parsed by either.
return results['rietveld']
class GerritChangeNotExists(Exception): class GerritChangeNotExists(Exception):
......
This diff is collapsed.
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment