Commit 9bb7b96c authored by Edward Lemur's avatar Edward Lemur Committed by Commit Bot

git-rebase-update: Make tests run on Python 3.

Bug: 1009809
Change-Id: I47c9a468b2922248b823ebae5e71863a698c30f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1889166Reviewed-by: 's avatarAnthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
parent 48cda092
...@@ -61,8 +61,8 @@ def main(args): ...@@ -61,8 +61,8 @@ def main(args):
run('checkout', '--track', opts.upstream, '-b', opts.branch_name) run('checkout', '--track', opts.upstream, '-b', opts.branch_name)
get_or_create_merge_base(opts.branch_name) get_or_create_merge_base(opts.branch_name)
except subprocess2.CalledProcessError as cpe: except subprocess2.CalledProcessError as cpe:
sys.stdout.write(cpe.stdout) sys.stdout.write(cpe.stdout.decode('utf-8', 'replace'))
sys.stderr.write(cpe.stderr) sys.stderr.write(cpe.stderr.decode('utf-8', 'replace'))
return 1 return 1
sys.stderr.write('Switched to branch %s.\n' % opts.branch_name) sys.stderr.write('Switched to branch %s.\n' % opts.branch_name)
return 0 return 0
......
...@@ -42,7 +42,7 @@ def main(args): ...@@ -42,7 +42,7 @@ def main(args):
if branch_config(branch, 'remote') == '.': if branch_config(branch, 'remote') == '.':
set_branch_config(branch, 'merge', 'refs/heads/' + opts.new_name) set_branch_config(branch, 'merge', 'refs/heads/' + opts.new_name)
except subprocess2.CalledProcessError as cpe: except subprocess2.CalledProcessError as cpe:
sys.stderr.write(cpe.stderr) sys.stderr.write(cpe.stderr.decode('utf-8', 'replace'))
return 1 return 1
return 0 return 0
......
#!/usr/bin/env python #!/usr/bin/env vpython3
# Copyright 2014 The Chromium Authors. All rights reserved. # Copyright 2014 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be # Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file. # found in the LICENSE file.
"""Unit tests for git_rebase_update.py""" """Unit tests for git_rebase_update.py"""
from __future__ import print_function
from __future__ import unicode_literals
import os import os
import sys import sys
...@@ -24,7 +27,7 @@ class GitRebaseUpdateTest(git_test_utils.GitRepoReadWriteTestBase): ...@@ -24,7 +27,7 @@ class GitRebaseUpdateTest(git_test_utils.GitRepoReadWriteTestBase):
@classmethod @classmethod
def getRepoContent(cls, commit): def getRepoContent(cls, commit):
# Every commit X gets a file X with the content X # Every commit X gets a file X with the content X
return {commit: {'data': commit}} return {commit: {'data': commit.encode('utf-8')}}
@classmethod @classmethod
def setUpClass(cls): def setUpClass(cls):
...@@ -119,7 +122,7 @@ class GitRebaseUpdateTest(git_test_utils.GitRepoReadWriteTestBase): ...@@ -119,7 +122,7 @@ class GitRebaseUpdateTest(git_test_utils.GitRepoReadWriteTestBase):
self.assertEqual(self.repo['E'], self.origin['E']) self.assertEqual(self.repo['E'], self.origin['E'])
with self.repo.open('bob', 'wb') as f: with self.repo.open('bob', 'wb') as f:
f.write('testing auto-freeze/thaw') f.write(b'testing auto-freeze/thaw')
output, _ = self.repo.capture_stdio(self.reup.main) output, _ = self.repo.capture_stdio(self.reup.main)
self.assertIn('Cannot rebase-update', output) self.assertIn('Cannot rebase-update', output)
...@@ -158,7 +161,7 @@ class GitRebaseUpdateTest(git_test_utils.GitRepoReadWriteTestBase): ...@@ -158,7 +161,7 @@ class GitRebaseUpdateTest(git_test_utils.GitRepoReadWriteTestBase):
self.assertIn('sub_K up-to-date', output) self.assertIn('sub_K up-to-date', output)
with self.repo.open('bob') as f: with self.repo.open('bob') as f:
self.assertEqual('testing auto-freeze/thaw', f.read()) self.assertEqual(b'testing auto-freeze/thaw', f.read())
self.assertEqual(self.repo.git('status', '--porcelain').stdout, '?? bob\n') self.assertEqual(self.repo.git('status', '--porcelain').stdout, '?? bob\n')
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment