Commit 93efa031 authored by jam@chromium.org's avatar jam@chromium.org

Revert 77913 - Regression: Editor Linux Fix for gcl.

Editor doesn't come up due to Shell=True

BUG=none
TEST=linux and win works
Review URL: http://codereview.chromium.org/6679023

TBR=mhm@chromium.org
Review URL: http://codereview.chromium.org/6684022

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77928 0039d316-1c4b-4281-b951-d872f2087c98
parent 37248c0b
......@@ -1063,9 +1063,10 @@ def CMDchange(args):
os.write(handle, text)
os.close(handle)
result = None
try:
if not silent:
subprocess.check_call(['env', GetEditor(), filename])
subprocess.check_call(['env', GetEditor(), filename], shell=True)
result = gclient_utils.FileRead(filename, 'r')
finally:
os.remove(filename)
......
......@@ -710,8 +710,9 @@ def UserEditedLog(starting_text):
fileobj.write(starting_text)
fileobj.close()
result = None
try:
subprocess.check_call(['env', editor, filename])
subprocess.check_call(['env', editor, filename], shell=True)
fileobj = open(filename)
result = fileobj.read()
fileobj.close()
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment