Commit 7298625c authored by Takuto Ikuta's avatar Takuto Ikuta Committed by LUCI CQ

recipes: use python3 for git_footers.py

Bug: 1327534
Recipe-Nontrivial-Roll: chromiumos
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited
Recipe-Nontrivial-Roll: infra
Change-Id: I5c84648eef8930f51d3809692d1cb3ffa46db6f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3775846
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: 's avatarGavin Mak <gavinmak@google.com>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
parent f3edc504
...@@ -799,7 +799,7 @@ Returns: ...@@ -799,7 +799,7 @@ Returns:
&emsp; **@property**<br>&mdash; **def [presubmit\_support\_path](/recipes/recipe_modules/presubmit/api.py#24)(self):** &emsp; **@property**<br>&mdash; **def [presubmit\_support\_path](/recipes/recipe_modules/presubmit/api.py#24)(self):**
### *recipe_modules* / [tryserver](/recipes/recipe_modules/tryserver) ### *recipe_modules* / [tryserver](/recipes/recipe_modules/tryserver)
[DEPS](/recipes/recipe_modules/tryserver/__init__.py#7): [gerrit](#recipe_modules-gerrit), [git](#recipe_modules-git), [git\_cl](#recipe_modules-git_cl), [recipe\_engine/buildbucket][recipe_engine/recipe_modules/buildbucket], [recipe\_engine/context][recipe_engine/recipe_modules/context], [recipe\_engine/json][recipe_engine/recipe_modules/json], [recipe\_engine/led][recipe_engine/recipe_modules/led], [recipe\_engine/path][recipe_engine/recipe_modules/path], [recipe\_engine/platform][recipe_engine/recipe_modules/platform], [recipe\_engine/properties][recipe_engine/recipe_modules/properties], [recipe\_engine/python][recipe_engine/recipe_modules/python], [recipe\_engine/raw\_io][recipe_engine/recipe_modules/raw_io], [recipe\_engine/step][recipe_engine/recipe_modules/step] [DEPS](/recipes/recipe_modules/tryserver/__init__.py#7): [gerrit](#recipe_modules-gerrit), [git](#recipe_modules-git), [git\_cl](#recipe_modules-git_cl), [recipe\_engine/buildbucket][recipe_engine/recipe_modules/buildbucket], [recipe\_engine/context][recipe_engine/recipe_modules/context], [recipe\_engine/json][recipe_engine/recipe_modules/json], [recipe\_engine/led][recipe_engine/recipe_modules/led], [recipe\_engine/path][recipe_engine/recipe_modules/path], [recipe\_engine/platform][recipe_engine/recipe_modules/platform], [recipe\_engine/properties][recipe_engine/recipe_modules/properties], [recipe\_engine/raw\_io][recipe_engine/recipe_modules/raw_io], [recipe\_engine/step][recipe_engine/recipe_modules/step]
PYTHON_VERSION_COMPATIBILITY: PY2+3 PYTHON_VERSION_COMPATIBILITY: PY2+3
...@@ -880,7 +880,7 @@ Args: ...@@ -880,7 +880,7 @@ Args:
Returned paths will be relative to to api.path['root']. Returned paths will be relative to to api.path['root'].
&mdash; **def [get\_footer](/recipes/recipe_modules/tryserver/api.py#373)(self, tag, patch_text=None):** &mdash; **def [get\_footer](/recipes/recipe_modules/tryserver/api.py#375)(self, tag, patch_text=None):**
Gets a specific tag from a CL description Gets a specific tag from a CL description
...@@ -903,11 +903,11 @@ Returns true iff the properties exist to match a Gerrit issue. ...@@ -903,11 +903,11 @@ Returns true iff the properties exist to match a Gerrit issue.
Returns true iff we have a change to check out. Returns true iff we have a change to check out.
&mdash; **def [normalize\_footer\_name](/recipes/recipe_modules/tryserver/api.py#381)(self, footer):** &mdash; **def [normalize\_footer\_name](/recipes/recipe_modules/tryserver/api.py#383)(self, footer):**
&mdash; **def [require\_is\_tryserver](/recipes/recipe_modules/tryserver/api.py#220)(self):** &mdash; **def [require\_is\_tryserver](/recipes/recipe_modules/tryserver/api.py#220)(self):**
&mdash; **def [set\_change](/recipes/recipe_modules/tryserver/api.py#384)(self, change):** &mdash; **def [set\_change](/recipes/recipe_modules/tryserver/api.py#386)(self, change):**
Set the gerrit change for this module. Set the gerrit change for this module.
......
...@@ -15,7 +15,6 @@ DEPS = [ ...@@ -15,7 +15,6 @@ DEPS = [
'recipe_engine/path', 'recipe_engine/path',
'recipe_engine/platform', 'recipe_engine/platform',
'recipe_engine/properties', 'recipe_engine/properties',
'recipe_engine/python',
'recipe_engine/raw_io', 'recipe_engine/raw_io',
'recipe_engine/step', 'recipe_engine/step',
] ]
...@@ -364,10 +364,12 @@ class TryserverApi(recipe_api.RecipeApi): ...@@ -364,10 +364,12 @@ class TryserverApi(recipe_api.RecipeApi):
'No patch text or associated changelist, cannot get footers') #pragma: nocover 'No patch text or associated changelist, cannot get footers') #pragma: nocover
def _get_footer_step(self, patch_text): def _get_footer_step(self, patch_text):
result = self.m.python( result = self.m.step('parse description', [
'parse description', self.repo_resource('git_footers.py'), 'python3',
args=['--json', self.m.json.output()], self.repo_resource('git_footers.py'), '--json',
stdin=self.m.raw_io.input(data=patch_text)) self.m.json.output()
],
stdin=self.m.raw_io.input(data=patch_text))
return result.json.output return result.json.output
def get_footer(self, tag, patch_text=None): def get_footer(self, tag, patch_text=None):
......
[ [
{ {
"cmd": [ "cmd": [
"python", "python3",
"RECIPE_REPO[depot_tools]/git_footers.py", "RECIPE_REPO[depot_tools]/git_footers.py",
"--json", "--json",
"/path/to/tmp/json" "/path/to/tmp/json"
...@@ -26,7 +26,7 @@ ...@@ -26,7 +26,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python", "python3",
"RECIPE_REPO[depot_tools]/git_footers.py", "RECIPE_REPO[depot_tools]/git_footers.py",
"--json", "--json",
"/path/to/tmp/json" "/path/to/tmp/json"
......
...@@ -116,7 +116,7 @@ ...@@ -116,7 +116,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python", "python3",
"RECIPE_REPO[depot_tools]/git_footers.py", "RECIPE_REPO[depot_tools]/git_footers.py",
"--json", "--json",
"/path/to/tmp/json" "/path/to/tmp/json"
...@@ -204,7 +204,7 @@ ...@@ -204,7 +204,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python", "python3",
"RECIPE_REPO[depot_tools]/git_footers.py", "RECIPE_REPO[depot_tools]/git_footers.py",
"--json", "--json",
"/path/to/tmp/json" "/path/to/tmp/json"
......
...@@ -116,7 +116,7 @@ ...@@ -116,7 +116,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python", "python3",
"RECIPE_REPO[depot_tools]/git_footers.py", "RECIPE_REPO[depot_tools]/git_footers.py",
"--json", "--json",
"/path/to/tmp/json" "/path/to/tmp/json"
...@@ -204,7 +204,7 @@ ...@@ -204,7 +204,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python", "python3",
"RECIPE_REPO[depot_tools]/git_footers.py", "RECIPE_REPO[depot_tools]/git_footers.py",
"--json", "--json",
"/path/to/tmp/json" "/path/to/tmp/json"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment