Commit 6cfe8d43 authored by Paweł Hajdan, Jr's avatar Paweł Hajdan, Jr Committed by Commit Bot

Add disable_syntax_validation gclient config to easily whitelist builders

Bug: 570091
Change-Id: Icb15bcd354c9b524674c6b4496f430c26cf7b89e
Reviewed-on: https://chromium-review.googlesource.com/521482Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: 's avatarJohn Budorick <jbudorick@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
parent bcec9e74
...@@ -243,7 +243,7 @@ class BotUpdateApi(recipe_api.RecipeApi): ...@@ -243,7 +243,7 @@ class BotUpdateApi(recipe_api.RecipeApi):
cmd.append('--gerrit_no_reset') cmd.append('--gerrit_no_reset')
if gerrit_no_rebase_patch_ref: if gerrit_no_rebase_patch_ref:
cmd.append('--gerrit_no_rebase_patch_ref') cmd.append('--gerrit_no_rebase_patch_ref')
if disable_syntax_validation: if disable_syntax_validation or cfg.disable_syntax_validation:
cmd.append('--disable-syntax-validation') cmd.append('--disable-syntax-validation')
# Inject Json output for testing. # Inject Json output for testing.
......
...@@ -90,6 +90,8 @@ def BaseConfig(USE_MIRROR=True, CACHE_DIR=None, ...@@ -90,6 +90,8 @@ def BaseConfig(USE_MIRROR=True, CACHE_DIR=None,
required=False, required=False,
hidden=True), hidden=True),
disable_syntax_validation = Single(bool, empty_val=False, required=False),
USE_MIRROR = Static(bool(USE_MIRROR)), USE_MIRROR = Static(bool(USE_MIRROR)),
# TODO(tandrii): remove PATCH_PROJECT field. # TODO(tandrii): remove PATCH_PROJECT field.
# DON'T USE THIS. WILL BE REMOVED. # DON'T USE THIS. WILL BE REMOVED.
...@@ -106,6 +108,10 @@ def ChromiumGitURL(_c, *pieces): ...@@ -106,6 +108,10 @@ def ChromiumGitURL(_c, *pieces):
def ChromeInternalGitURL(_c, *pieces): # pragma: no cover def ChromeInternalGitURL(_c, *pieces): # pragma: no cover
return '/'.join(('https://chrome-internal.googlesource.com',) + pieces) return '/'.join(('https://chrome-internal.googlesource.com',) + pieces)
@config_ctx()
def disable_syntax_validation(c):
c.disable_syntax_validation = True
@config_ctx() @config_ctx()
def android(c): def android(c):
c.target_os.add('android') c.target_os.add('android')
......
...@@ -20,6 +20,7 @@ TEST_CONFIGS = [ ...@@ -20,6 +20,7 @@ TEST_CONFIGS = [
'crashpad', 'crashpad',
'custom_tabs_client', 'custom_tabs_client',
'dart', 'dart',
'disable_syntax_validation',
'gerrit_test_cq_normal', 'gerrit_test_cq_normal',
'gyp', 'gyp',
'infra', 'infra',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment