Commit 22950055 authored by maruel@chromium.org's avatar maruel@chromium.org

Make sure the GAE SDK don't look for SDK updates while running presubmit checks

Otherwise the local Rietveld instance could mysteriously hang.

TEST=presubmit check won't fail even if an old version of the SDK is used
BUG=none

Review URL: http://codereview.chromium.org/6652002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79338 0039d316-1c4b-4281-b951-d872f2087c98
parent 0d1bdead
......@@ -102,10 +102,16 @@ class LocalRietveld(object):
self.out = open(os.devnull, 'w')
self.err = open(os.devnull, 'w')
output = []
cmd = [
self.dev_app,
'--skip_sdk_update_check',
'.',
'--port=%d' % self.port,
'--datastore_path=' + os.path.join(self.rietveld, 'tmp.db'),
'-c']
self.test_server = subprocess.Popen(
[self.dev_app, self.rietveld, '--port=%d' % self.port,
'--datastore_path=' + os.path.join(self.rietveld, 'tmp.db'), '-c'],
stdout=self.out, stderr=self.err, env=self.env)
cmd, stdout=self.out, stderr=self.err, env=self.env,
cwd=self.rietveld)
# Loop until port 127.0.0.1:port opens or the process dies.
while not test_port(self.port):
self.test_server.poll()
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment