Commit 22879a78 authored by maruel@chromium.org's avatar maruel@chromium.org

Fix git-cl quoting, yet again.

Using "%@" will correctly requote quoted arguments. Tested with repro case.
The fix in r232184 missed the necessary argument quoting.

R=iannucci@chromium.org
BUG=314192
BUG=241769

Review URL: https://codereview.chromium.org/47873010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@232501 0039d316-1c4b-4281-b951-d872f2087c98
parent 4f4e76fc
...@@ -21,7 +21,7 @@ fi ...@@ -21,7 +21,7 @@ fi
# "$base_dir"/update_depot_tools # "$base_dir"/update_depot_tools
if [ -e "$base_dir/python.bat" -a $MINGW = 0 ]; then if [ -e "$base_dir/python.bat" -a $MINGW = 0 ]; then
PYTHONDONTWRITEBYTECODE=1 cmd.exe //c $base_dir\\python.bat $base_dir\\git_cl.py $@ PYTHONDONTWRITEBYTECODE=1 cmd.exe //c "$base_dir\\python.bat" "$base_dir\\git_cl.py" "$@"
else else
PYTHONDONTWRITEBYTECODE=1 exec "$base_dir/git_cl.py" "$@" PYTHONDONTWRITEBYTECODE=1 exec "$base_dir/git_cl.py" "$@"
fi fi
...@@ -15,7 +15,7 @@ else ...@@ -15,7 +15,7 @@ else
fi fi
if [ -e "$base_dir/python.bat" -a $MINGW = 0 ]; then if [ -e "$base_dir/python.bat" -a $MINGW = 0 ]; then
PYTHONDONTWRITEBYTECODE=1 cmd.exe //c $base_dir\\python.bat $base_dir\\git_try.py $@ PYTHONDONTWRITEBYTECODE=1 cmd.exe //c "$base_dir\\python.bat" "$base_dir\\git_try.py" "$@"
else else
PYTHONDONTWRITEBYTECODE=1 exec "$base_dir/git_try.py" "$@" PYTHONDONTWRITEBYTECODE=1 exec "$base_dir/git_try.py" "$@"
fi fi
...@@ -13,7 +13,7 @@ OUTPUT="$(uname | grep 'MINGW')" ...@@ -13,7 +13,7 @@ OUTPUT="$(uname | grep 'MINGW')"
MINGW=$? MINGW=$?
if [ -e "$base_dir/python.bat" -a $MINGW = 0 ]; then if [ -e "$base_dir/python.bat" -a $MINGW = 0 ]; then
PYTHONDONTWRITEBYTECODE=1 cmd.exe //c $base_dir\\python.bat $base_dir\\pylint.py $@ PYTHONDONTWRITEBYTECODE=1 cmd.exe //c "$base_dir\\python.bat" "$base_dir\\pylint.py" "$@"
else else
PYTHONDONTWRITEBYTECODE=1 exec "$base_dir/pylint.py" "$@" PYTHONDONTWRITEBYTECODE=1 exec "$base_dir/pylint.py" "$@"
fi fi
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment