Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Contribute to GitLab
  • Sign in / Register
C
Chromium_Depot_tools
  • Project
    • Project
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Linshizhi
  • Chromium_Depot_tools
  • Repository

Switch branch/tag
  • chromium_depot_tools
  • recipes
  • recipe_modules
  • gitiles
  • api.py
Find file
BlameHistoryPermalink
  • Aravind Vasudevan's avatar
    Reland "Break make_encoded_file into two functions" · 23ddab22
    Aravind Vasudevan authored May 04, 2022
    This is a reland of commit 5e49eda5
    
    Original change's description:
    > Break make_encoded_file into two functions
    >
    > The python3 fallback for `make_encoded_file()` produces different results on py2 and py3 when bytes are passed. This CL makes it clear breaking it into two methods, one for text and another for bytes. This CL also adds a fallback in `download_file` for py3 to return bytes when it cannot decode the downloaded file into utf-8.
    >
    > Recipe-Manual-Change: chromiumos
    > Change-Id: I3d313e430c852e179825bc24bf4a58ce84440b2a
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3595026
    > Reviewed-by: Gavin Mak <gavinmak@google.com>
    > Reviewed-by: Greg Edelston <gredelston@google.com>
    > Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
    
    Recipe-Manual-Change: chromiumos
    Change-Id: I321f797ae4a00deed7920ee6f80d666954b07c7d
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3625907Reviewed-by: 's avatarGreg Edelston <gredelston@google.com>
    Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
    23ddab22
api.py 9.89 KB
EditWeb IDE

Replace api.py

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.