Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Contribute to GitLab
  • Sign in / Register
C
Chromium_Depot_tools
  • Project
    • Project
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Linshizhi
  • Chromium_Depot_tools
  • Repository

Switch branch/tag
  • chromium_depot_tools
  • goma_ctl
Find file
BlameHistoryPermalink
  • Bruce Dawson's avatar
    Reland "Reland "use python3 for goma related scripts"" · a806594b
    Bruce Dawson authored Jun 28, 2021
    This reverts commit fc3fb20e.
    
    Reason for revert: Previous versions of this changed used %scriptdir% in
    goma_ctl.bat and goma_auth.bat but never defined it. This eluded manual
    testing because these scripts would work properly as long as they were
    run from the depot_tools directory, but would fail when run from
    elsewhere.
    
    The fix to make this reland work can be found by comparing patchset 1 to
    patchset 3.
    
    Original change's description:
    > Revert "Reland "use python3 for goma related scripts""
    >
    > This reverts commit 2a6dffaf.
    >
    > Reason for revert: with this change in depot_tools when I run "goma_ctl ensure_start" from cmd.exe I get
    > "The system cannot find the path specified."
    >
    > Original change's description:
    > > Reland "use python3 for goma related scripts"
    > >
    > > This reverts commit 59140d43.
    > >
    > > Reason for revert:
    > > Make this works in git bash.
    > >
    > > Original change's description:
    > > > Revert "use python3 for goma related scripts"
    > > >
    > > > This reverts commit 138ec7c5.
    > > >
    > > > Reason for revert:
    > > > This might have caused the following issue:
    > > > https://bugs.chromium.org/p/chromium/issues/detail?id=1221233
    > > >
    > > > Original change's description:
    > > > > use python3 for goma related scripts
    > > > >
    > > > > This uses python3 like autoninja{,.bat}.
    > > > > https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja
    > > > > https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja.bat
    > > > >
    > > > > Change-Id: I4daf1892024358c5b7d88b1e32b15c82cb4411d2
    > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2968069
    > > > > Commit-Queue: Dirk Pranke <dpranke@google.com>
    > > > > Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
    > > > > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
    > > > > Reviewed-by: Dirk Pranke <dpranke@google.com>
    > > >
    > > > Change-Id: Ideb5004cf18c91c1404066622244a8527f5248f3
    > > > No-Presubmit: true
    > > > No-Tree-Checks: true
    > > > No-Try: true
    > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2972023
    > > > Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
    > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    > > > Commit-Queue: Dirk Pranke <dpranke@google.com>
    > > > Reviewed-by: Dirk Pranke <dpranke@google.com>
    > >
    > > Bug: 1221233
    > > Change-Id: I815a774faa2e4fbca0f262667ea89709a09e146b
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2979560
    > > Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
    > > Reviewed-by: Allen Bauer <kylixrd@chromium.org>
    > > Reviewed-by: Dirk Pranke <dpranke@google.com>
    > > Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
    > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
    >
    > Bug: 1221233
    > Change-Id: I5050b9199f3076e6d6f812b8bac01e8cd1dc53bf
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2992150
    > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    > Reviewed-by: Dirk Pranke <dpranke@google.com>
    > Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
    
    Bug: 1221233
    Change-Id: I50412a5ea62f1607660cb7a7ab8851251c3dfe91
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2992151Reviewed-by: 's avatarDirk Pranke <dpranke@google.com>
    Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
    a806594b
goma_ctl 556 Bytes
EditWeb IDE

Replace goma_ctl

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.