• raphael.kubo.da.costa@intel.com's avatar
    presubmit_unittest: Fix pylint errors. · e589f98b
    raphael.kubo.da.costa@intel.com authored
    The recent pylint 1.3.1 and 1.4.0 upgrades have caused some new errors
    to be reported for presubmit_unittest:
    
    * presubmit_support.InputApi.AffectedFiles() expectes a parameter called
      |include_deletes|, not |include_deleted|.
    
    * The mock AffectedFiles() implementation in
      CannedChecksUnittest.testCannedCheckChangeHasNoTabs() had its
      signature updated to match the one in presubmit_support.InputApi,
      otherwise pylint would (erroneously) consider that this mock
      implementation was used in all other AffectedFiles() invocations in
      CannedChecksUnittest and complain that some parameters were missing.
      It makes more sense to do this than disable the check and miss real
      problems in the future.
    
    R=maruel@chromium.org, iannucci@chromium.org, pgervais@chromium.org
    BUG=443232
    
    Review URL: https://codereview.chromium.org/802403003
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293468 0039d316-1c4b-4281-b951-d872f2087c98
    e589f98b
presubmit_unittest.py 114 KB