• Josip Sokcevic's avatar
    Revert "Set a default got_revision property in the bot_update json output." · a0382d39
    Josip Sokcevic authored
    This reverts commit 05381726.
    
    Reason for revert: we reverted got_revision change, and this change
    itself may be causing some other failues.
    
    Original change's description:
    > Set a default got_revision property in the bot_update json output.
    >
    > The bot_update.py script sets a got_revision property by default even if
    > it is not present in the reverse revision mapping. This results in an
    > uncaught exception when set_output_commit is set to True if got_revision
    > isn't present in the reverse revision mapping, but it isn't caught until
    > production because the test API doesn't match that behavior. This change
    > updates the test API method to match the behavior of the script.
    >
    > Recipe-Nontrivial-Roll: build
    > Recipe-Nontrivial-Roll: build_limited
    > Recipe-Nontrivial-Roll: chromiumos
    > Recipe-Nontrivial-Roll: infra
    > Change-Id: Ideefa9d77d2a816ae66a2bb52737264ed3f5bcee
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3575361
    > Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
    > Reviewed-by: Josip Sokcevic <sokcevic@google.com>
    > Commit-Queue: Garrett Beaty <gbeaty@google.com>
    > Auto-Submit: Garrett Beaty <gbeaty@google.com>
    
    Change-Id: Ie975dfe39e7b8997336761e12f53f3046359d825
    Recipe-Nontrivial-Roll: build
    Recipe-Nontrivial-Roll: build_limited
    Recipe-Nontrivial-Roll: chromiumos
    Recipe-Nontrivial-Roll: infra
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3578820
    Auto-Submit: Josip Sokcevic <sokcevic@google.com>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    a0382d39
api.py 22.9 KB