• Bruce Dawson's avatar
    Tag cpplint errors · ac96470e
    Bruce Dawson authored
    A typical cpplint error report during a presubmit looks like this:
    
        .../linux_ui.cc:64:  Almost always, snprintf is better than strcpy  [runtime/printf] [4]
        ...
        Changelist failed cpplint.py check.
    
    The problem is that the details of the error go to stderr when
    CheckChangeLintsClean is run, whereas the "Changelist failed cpplint.py
    check." message is printed at the end of the run. If there a lot of
    errors, warnings, or messages then the association between them can be
    completely lost.
    
    This change adds the tag (cpplint) to the error messages, and adds a
    comment to the "failed cpplint.py check" message to suggest looking for
    the tag.
    
    Bug: 1309977
    Change-Id: I0d073b57f215e28495cbc3e009cab6ac2f23b65e
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3632947
    Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
    Reviewed-by: 's avatarAravind Vasudevan <aravindvasudev@google.com>
    ac96470e
cpplint.py 232 KB