• Marc-Antoine Ruel's avatar
    python3 improvements · 8e57b4bc
    Marc-Antoine Ruel authored
    Ran:
      vi $(git grep --name-only iteritems | grep -v third_party)
      vi $(git grep --name-only itervalues | grep -v third_party)
      vi $(git grep --name-only 'print ' | grep -v third_party)
    
    and edited the files quickly with adhoc macros. Then ran in recipes/:
      ./recipes.py test train
    
    There was only a small subset of files that had been updated to use
    six.iteritems() and six.itervalues(). Since the dataset size that is
    being used in gclient is small (pretty much always below 200 items),
    it's better to just switch to .items() right away and take the temporary
    performance hit, so that we don't need to come back to rewrite the code.
    
    Recipe-Nontrivial-Roll: build
    Bug: 984182
    Change-Id: I5faf11486b66b0d73c9098ab0f2ce1b15a45c53e
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1854900
    Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
    Reviewed-by: 's avatarEdward Lesmes <ehmaldonado@chromium.org>
    Auto-Submit: Marc-Antoine Ruel <maruel@chromium.org>
    8e57b4bc
api.py 10.3 KB