• Aaron Gable's avatar
    git-cl-upload: Set all reviewers and ccs in a single batch api call · 6dadfbfc
    Aaron Gable authored
    The old system had two faults:
    * It set reviewers and ccs via different mechanisms, which is confusing
    * It set CCs with a single call for each, resulting in N separate emails,
      with each email going to the uploader and all reviewers and all previous
      CCs.
    
    This new system just collects all reviewers and CCs, and sets them
    in a single call. That call will fail if *any* of the individual
    reviewers or ccs fail, so it also parses the response and retries with
    only the ones which would have succeeded on their own. If that second
    call fails, or the first fails in an unexpected way, it raises an
    exception like normal
    
    Bug: 710028
    Change-Id: I1be508487a41f0b68f9c41908229b8f5342830a3
    Reviewed-on: https://chromium-review.googlesource.com/479712
    Commit-Queue: Aaron Gable <agable@chromium.org>
    Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
    6dadfbfc
gerrit_util.py 28.1 KB