• Bruce Dawson's avatar
    Actually enable crash dump collection on builders · 93e1a76e
    Bruce Dawson authored
    Change crrev.com/1825163003 attempted to enable crash dump collection
    on build machines, and it worked fine on local testing. However it only
    worked because local testing was done using 64-bit Python. The builders
    use python from depot_tools which is 32-bit Python so the changes all
    went to "HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Microsoft" instead of
    to "HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft", which means they were
    ignored. For a year. This made investigation of linker crashes more
    complicated than needed.
    
    This change uses the necessary winreg.KEY_WOW64_64KEY dance so that the
    64-bit registry is always used, whether running 32-bit Python or 64-bit
    Python. Both versions were tested locally. The behavior on 32-bit
    Windows is unknown but we don't support building on 32-bit Windows
    anyway, and any failures would be rendered harmless by the try/except
    block.
    
    R=scottmg@chromium.org
    BUG=704286
    
    Change-Id: I6abc0e1e9c69b9a4e4b9c705bea9e4faadd0945c
    Reviewed-on: https://chromium-review.googlesource.com/473567Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
    Reviewed-by: 's avatarScott Graham <scottmg@chromium.org>
    Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
    93e1a76e
get_toolchain_if_necessary.py 19.1 KB