-
Aaron Gable authored
This reverts commit 6d7ab1bf. Reason for revert: Stacktrace: File "/s/depot_tools/gerrit_util.py", line 816, in GetAccountDetails return ReadHttpJsonResponse(conn) File "/s/depot_tools/gerrit_util.py", line 376, in ReadHttpJsonResponse fh = ReadHttpResponse(conn, accept_statuses) File "/s/depot_tools/gerrit_util.py", line 365, in ReadHttpResponse if response.status not in accept_statuses: TypeError: argument of type 'NoneType' is not iterable Original change's description: > Refactor ReadHttpResponse to be error-friendlier > > Gerrit sometimes returns a full response json object at > the same time as returning a non-200 status code. This > refactor makes it easier for calling code to request > access to that object and handle error cases on its own. > > Bug: 710028 > Change-Id: Id1017d580d2fb843d5ca6287efcfed8775c52cd6 > Reviewed-on: https://chromium-review.googlesource.com/479450 > Commit-Queue: Aaron Gable <agable@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > TBR=agable@chromium.org,tandrii@chromium.org,chromium-reviews@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Ia9d9ce835e207a32e7cc8ee35c0cf40c823c7b78 Reviewed-on: https://chromium-review.googlesource.com/481059Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
382674be