• Dan Jacques's avatar
    [git retry] Fix Git wrapper fallthrough. · e2af38e0
    Dan Jacques authored
    Currently, when the Infra Git wrapper is installed in PATH and a user
    calls "git retry", the "git_retry.py" script is supposed to ignore the
    request and fall through to the underlying command, relying on the Git
    wrapper to handle retries.
    
    However, Git apparently prepends its own executable path to PATH when it
    is called, preventing the Git wrapper from being invoked the second time
    and removing retries altogether.
    
    We circumvent this by removing Git's new PATH influence when falling
    through.
    
    BUG=chromium:721450
    TEST=local
      - Ran locally before and after patch, confirmed that after
      successfully retries throgh the wrapper.
    
    R=agable@chromium.org, iannucci@chromium.org
    
    Change-Id: Iae3d7a8bf805a5ba2bf827b06006a990d94e96d9
    Reviewed-on: https://chromium-review.googlesource.com/506374Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
    Commit-Queue: Daniel Jacques <dnj@chromium.org>
    e2af38e0
git_retry.py 5.66 KB