• Fumitoshi Ukai's avatar
    Reland "put goma client in depot_tools" · 27bd4e42
    Fumitoshi Ukai authored
    This reverts commit a0aed87f.
    
    Reason for revert: install goma client without update_hook
    
    update_hook would disrupt current users, so start without update_hook,
    which means goma cient in depot_tools user might need to
    restart compiler_proxy manually when updated.
     https://docs.google.com/document/d/1pnwfkU6Rd9dRtQC0sg2vATmyRbkYWhnNUTD5k1PddC0/edit#
    
    Original change's description:
    > Revert "put goma client in depot_tools"
    >
    > This reverts commit 77780358.
    >
    > Reason for revert: AttributeError: 'GomaEnvPosix' object has no attribute 'RestartCompilerProxy'
    >
    > Original change's description:
    > > put goma client in depot_tools
    > >
    > > install goma client cipd package in depot_tools.
    > >
    > > should not use $MYPATH/goma_ctl in cipd_bin_setup
    > > since $MYPATH/goma_ctl uses cipd_bin_setup in itself,
    > > so causing recursive calls.
    > > invoke python to run .cipd/goma_ctl.py in cipd_bin_setup
    > > instead.
    > >
    > > Bug: b/77663154
    > > Change-Id: I9f82c766a886a2acfb899e3594e5f05a7b7bc75a
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1866350
    > > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
    > > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    > > Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>
    >
    > TBR=sque@chromium.org,ukai@chromium.org,yyanagisawa@google.com,vadimsh@chromium.org,dpranke@chromium.org,tikuta@chromium.org,ehmaldonado@chromium.org,yekuang@google.com
    >
    > Change-Id: Ie050dfb524dd885634c31be829d733613e80aece
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: b/77663154
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1872129
    > Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>
    > Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>
    
    TBR=sque@chromium.org,ukai@chromium.org,yyanagisawa@google.com,vadimsh@chromium.org,dpranke@chromium.org,tikuta@chromium.org,ehmaldonado@chromium.org,yekuang@google.com
    
    
    Bug: b/77663154
    Change-Id: I8bb51631e4418ff63953099814bdb464128eb279
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1875982Reviewed-by: 's avatarDirk Pranke <dpranke@chromium.org>
    Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>
    27bd4e42
goma_ctl 362 Bytes