• Clemens Hammacher's avatar
    [wasm] Register and release protected instructions only once · fffa3317
    Clemens Hammacher authored
    We currently have a system where the protected instructions are
    unregistered when the last instance dies, and registered again on the
    next instantiation. This is triggered by {WasmCompiledModule::Reset}.
    Since the reference to the {NativeModule} will move to the
    {WasmModuleObject}, and this object stays alive even if the last
    instance dies, this will become hard to maintain.
    It will also make it harder to share wasm code across isolates.
    This CL refactors this to register trap handler data once when the code
    is added to the {NativeModule}, and releases it if the code dies.
    
    R=mstarzinger@chromium.org
    CC=​eholk@chromium.org
    
    Bug: v8:5277
    Change-Id: I3f1b336095230b255f3849c271b37b62f2b96cd6
    Reviewed-on: https://chromium-review.googlesource.com/1103567
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#53791}
    fffa3317
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...