• Leszek Swirski's avatar
    [compiler] Use SmallVector for Parser->BG thread use counts · ffdc50a9
    Leszek Swirski authored
    Change the off-thread parse to fill a SmallVector<UseCounterFeature, 8>
    on the BG compile task, rather than an int[kUseCounterFeatureCount]
    array. This allows us to keep the loop over use counts in the compile
    task finalization short by avoiding looping over unused counters.
    
    The value 8 was chosen as a "reasonable small number"; experimenting on
    our benchmarks shows a max of 3 use counts collected per compile (and
    at a vanishingly low percentage of all compiles).
    
    Passing around an explicit SmallVector<UseCounterFeature, 8> pointer,
    complete with size, is a bit ugly, but since it's used only in this one
    place (Parser -> BackgroundCompileTask) I can live with it to avoid
    further indirections. Typedeffing it is possible, but it's not clear
    where, since it's needed in both src/codegen/compiler.h and
    src/parsing/parser.h, and neither includes the other.
    
    Change-Id: Idb73e2f56fa9e8911ea29fb810d7562246f19d46
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3318662Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#78305}
    ffdc50a9
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
security Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...