• Benedikt Meurer's avatar
    [inspector] Add nonIndexedPropertiesOnly to Runtime.getProperties. · ffa4cda6
    Benedikt Meurer authored
    This introduces a new, optional `nonIndexedPropertiesOnly` flag to the
    `Runtime.getProperties` inspector request, which tells the inspector to
    only report properties whose name is not an (typed) array index. This is
    to support retrieving all properties except for the indexed ones when
    the DevTools front-end decides to use the array bucketing mechanism.
    Previously the DevTools front-end had some quite complicated logic in
    place to simulate this via injected JavaScript, but that logic didn't
    pick up internal properties and was also interfering with the inherited
    accessor mechanism. With this new flag, it's straight-forward to
    implement the correct behavior in the DevTools front-end.
    
    The corresponding devtools-frontend CL is https://crrev.com/c/3099011.
    
    Before: https://imgur.com/hMX6vaV.png
    After: https://imgur.com/MGgiuJQ.png
    Bug: chromium:1199701
    Change-Id: Iacbe9756ed8a2e6982efaebe1e7c606d37c05379
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3099686
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarPhilip Pfaffe <pfaffe@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#76360}
    ffa4cda6
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...