• Seth Brenith's avatar
    [wasm][arm64] Fix crash on atomic cmpxchg with large offset · e1fff28b
    Seth Brenith authored
    Liftoff can currently run out of registers when compiling an atomic
    compare-exchange instruction. In order to see this crash, the following
    conditions must be met:
    
    - The offset in the instruction doesn't fit in a 12-bit immediate
    - Either FLAG_untrusted_code_mitigations is false, or trap handlers are
      enabled, so that AddMemoryMasking decides to do nothing
    
    The fix proposed in this CL is just to defer allocation of a temporary
    register until after CalculateActualAddress has finished, because it
    might have also needed a temporary register.
    
    Change-Id: I28225614dcdbe2bcc9e52208f1e806baac89c5f1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2488840
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70687}
    e1fff28b
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
debugging Loading commit data...
fuzzer Loading commit data...
fuzzilli Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-api-tests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...