• jarin's avatar
    Revert of [turbofan] Osr value typing + dynamic type checks on entry.... · ff81734c
    jarin authored
    Revert of [turbofan] Osr value typing + dynamic type checks on entry. (patchset #5 id:80001 of https://codereview.chromium.org/2384113002/ )
    
    Reason for revert:
    Tanks the world.
    
    Original issue's description:
    > [turbofan] Osr value typing + dynamic type checks on entry.
    >
    > This introduces a new OsrGuard node that is inserted during graph building
    > to guard the inferred type of the OSR value.
    >
    > The type of the OSR value is inferred by running the typer before OSR
    > deconstruction, and then taking the type from the phi that takes the
    > OSR value. After the deconstruction, we throw the types away.
    >
    > At the moment we only support the SignedSmall OSR type and we always
    > pick the tagged representation. Later, we might want to support more
    > types (such as Number) and pick better representations (int32/float64).
    >
    > This CL also removes the OSR deconstruction tests because they build
    > unrealistic graph (no effect chain, no loop termination). I considered
    > adding the effect chains to the tests, but this would make the tests
    > even more brittle.
    >
    > Committed: https://crrev.com/1f5dc90a900d222da44bee3eff171a2ba1e3c076
    > Cr-Commit-Position: refs/heads/master@{#39971}
    
    TBR=bmeurer@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    
    Review-Url: https://codereview.chromium.org/2395783002
    Cr-Commit-Position: refs/heads/master@{#39985}
    ff81734c
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...