• bgeron's avatar
    [turbolizer] Show a label with a shorter parameter for some opcodes. · feb93dd6
    bgeron authored
    With this patch, every node in turbo-*.json has an opcode, a title, and
    a label. The label field is new; the opcode and title were already
    there. The title is for the mouseover text. The label is what will be
    displayed in the graph view, unless it's too long, in which case only
    the opcode will be displayed. (This is similar to the preexisting
    behaviour of putting titles in labels, except that the titles were
    rarely short enough to fit in a label.)
    
    With this patch, the labels generated are in practice the same as the
    titles we had before, except for LoadField and StoreField, which will be
    rendered as LoadField[[+432]] and StoreField[[+432]] (if 432 was the
    offset).
    
    This diff adds an overloadable method
    
        virtual void Operator1<T>::PrintParameter(ostream&, PrintVerbosity)
    
    for each type T to Operator1. Its default implementation just uses
    operator<<(ostream&, T const&) and adds square brackets around it, but
    it is overridden for FieldAccess to print "[+432]" in the example case.
    
    BUG=
    R=jarin,danno
    
    Review-Url: https://codereview.chromium.org/2093013002
    Cr-Commit-Position: refs/heads/master@{#37795}
    feb93dd6
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...