• Andreas Haas's avatar
    [wasm] Delay error messages for lazy compilation · fe53fbfc
    Andreas Haas authored
    With streaming compilation we delay the generation of errors until after
    all bytes are received, so that potentially better error messages get
    generated. With this CL we also delay the generation of errors in the
    combination of lazy compilation and streaming compilation.
    
    In particular, this CL does the following:
    * It avoids the creation of a `DecodeFail` task in
    `FinishAsyncCompileJobWithError`, which would create an error immediately before a potential name section arrived.
    * It calls `CompilationStateImpl::SetError()` so that an error is
    created once the stream finishes.
    * It removes the return value of `ProcessFunctionBody` so that wire
    bytes continue to be received even after a validation error.
    * It adds an early exit to `ProcessFunctionBody` if
    `CompilationStateImpl::failed()` is true, so that we don't continue
    validation after the first detected error.
    
    R=clemensb@chromium.org
    
    Bug: v8:12852
    Change-Id: Ie8c6be243a257ef62cbb29fea6b8e0c205060680
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3802691Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82181}
    fe53fbfc
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...