• Dan Elphick's avatar
    Reland "[heap] Make ReadOnlySpace use bump pointer allocation" · 32b911f9
    Dan Elphick authored
    This reverts commit f78d69fa.
    
    With https://chromium-review.googlesource.com/c/v8/v8/+/2243216,
    incorrect MemoryChunk::FromHeapObject uses are now fixed.
    
    Original change's description:
    > Revert "[heap] Make ReadOnlySpace use bump pointer allocation"
    > 
    > This reverts commit 81c34968 and also
    > 490f3580 which depends on the former.
    > 
    > Reason for revert: Break CFI tests in chromium https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/17438
    > Original change's description:
    > > [heap] Make ReadOnlySpace use bump pointer allocation
    > >
    > > This changes ReadOnlySpace to no longer be a PagedSpace but instead it
    > > is now a BaseSpace. BasicSpace is a new base class that Space inherits
    > > from and which has no allocation methods and does not dictate how the
    > > pages should be held.
    > >
    > > ReadOnlySpace unlike Space holds its pages as a
    > > std::vector<ReadOnlyPage>, where ReadOnlyPage directly subclasses
    > > BasicMemoryChunk, meaning they do not have prev_ and next_ pointers and
    > > cannot be held in a heap::List. This is desirable since with pointer
    > > compression we would like to remap these pages to different memory
    > > addresses which would be impossible with a heap::List.
    > >
    > > Since ReadOnlySpace no longer uses most of the code from the other
    > > Spaces it makes sense to simplify its memory allocation to use a simple
    > > bump pointer and always allocate a new page whenever an allocation
    > > exceeds the remaining space on the final page.
    > >
    > > Change-Id: Iee6d9f96cfb174b4026ee671ee4f897909b38418
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2209060
    > > Commit-Queue: Dan Elphick <delphick@chromium.org>
    > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#68137}
    > 
    > TBR=ulan@chromium.org,delphick@chromium.org
    > 
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    > 
    > Change-Id: I68c9834872e55eb833be081f8ff99b786bfa9894
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2232552
    > Commit-Queue: Dan Elphick <delphick@chromium.org>
    > Reviewed-by: Dan Elphick <delphick@chromium.org>
    > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#68211}
    
    TBR=ulan@chromium.org,delphick@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Change-Id: Id5b3cce41b5dec1dca816c05848d183790b1cc05
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2250254Reviewed-by: 's avatarDan Elphick <delphick@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Commit-Queue: Dan Elphick <delphick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68407}
    32b911f9
Name
Last commit
Last update
..
cppgc Loading commit data...
cppgc-js Loading commit data...
third-party Loading commit data...
OWNERS Loading commit data...
allocation-stats.h Loading commit data...
array-buffer-collector.cc Loading commit data...
array-buffer-collector.h Loading commit data...
array-buffer-sweeper.cc Loading commit data...
array-buffer-sweeper.h Loading commit data...
array-buffer-tracker-inl.h Loading commit data...
array-buffer-tracker.cc Loading commit data...
array-buffer-tracker.h Loading commit data...
barrier.h Loading commit data...
basic-memory-chunk.cc Loading commit data...
basic-memory-chunk.h Loading commit data...
code-object-registry.cc Loading commit data...
code-object-registry.h Loading commit data...
code-stats.cc Loading commit data...
code-stats.h Loading commit data...
combined-heap.cc Loading commit data...
combined-heap.h Loading commit data...
concurrent-allocator-inl.h Loading commit data...
concurrent-allocator.cc Loading commit data...
concurrent-allocator.h Loading commit data...
concurrent-marking.cc Loading commit data...
concurrent-marking.h Loading commit data...
embedder-tracing.cc Loading commit data...
embedder-tracing.h Loading commit data...
factory-base-inl.h Loading commit data...
factory-base.cc Loading commit data...
factory-base.h Loading commit data...
factory-inl.h Loading commit data...
factory.cc Loading commit data...
factory.h Loading commit data...
finalization-registry-cleanup-task.cc Loading commit data...
finalization-registry-cleanup-task.h Loading commit data...
free-list-inl.h Loading commit data...
free-list.cc Loading commit data...
free-list.h Loading commit data...
gc-idle-time-handler.cc Loading commit data...
gc-idle-time-handler.h Loading commit data...
gc-tracer.cc Loading commit data...
gc-tracer.h Loading commit data...
heap-controller.cc Loading commit data...
heap-controller.h Loading commit data...
heap-inl.h Loading commit data...
heap-write-barrier-inl.h Loading commit data...
heap-write-barrier.h Loading commit data...
heap.cc Loading commit data...
heap.h Loading commit data...
incremental-marking-inl.h Loading commit data...
incremental-marking-job.cc Loading commit data...
incremental-marking-job.h Loading commit data...
incremental-marking.cc Loading commit data...
incremental-marking.h Loading commit data...
invalidated-slots-inl.h Loading commit data...
invalidated-slots.cc Loading commit data...
invalidated-slots.h Loading commit data...
item-parallel-job.cc Loading commit data...
item-parallel-job.h Loading commit data...
large-spaces.cc Loading commit data...
large-spaces.h Loading commit data...
list.h Loading commit data...
local-allocator-inl.h Loading commit data...
local-allocator.h Loading commit data...
local-heap.cc Loading commit data...
local-heap.h Loading commit data...
mark-compact-inl.h Loading commit data...
mark-compact.cc Loading commit data...
mark-compact.h Loading commit data...
marking-visitor-inl.h Loading commit data...
marking-visitor.h Loading commit data...
marking-worklist.cc Loading commit data...
marking-worklist.h Loading commit data...
marking.cc Loading commit data...
marking.h Loading commit data...
memory-allocator.cc Loading commit data...
memory-allocator.h Loading commit data...
memory-chunk-inl.h Loading commit data...
memory-chunk.cc Loading commit data...
memory-chunk.h Loading commit data...
memory-measurement-inl.h Loading commit data...
memory-measurement.cc Loading commit data...
memory-measurement.h Loading commit data...
memory-reducer.cc Loading commit data...
memory-reducer.h Loading commit data...
new-spaces-inl.h Loading commit data...
new-spaces.cc Loading commit data...
new-spaces.h Loading commit data...
object-stats.cc Loading commit data...
object-stats.h Loading commit data...
objects-visiting-inl.h Loading commit data...
objects-visiting.cc Loading commit data...
objects-visiting.h Loading commit data...
off-thread-factory-inl.h Loading commit data...
off-thread-factory.cc Loading commit data...
off-thread-factory.h Loading commit data...
off-thread-heap.cc Loading commit data...
off-thread-heap.h Loading commit data...
paged-spaces-inl.h Loading commit data...
paged-spaces.cc Loading commit data...
paged-spaces.h Loading commit data...
read-only-heap-inl.h Loading commit data...
read-only-heap.cc Loading commit data...
read-only-heap.h Loading commit data...
read-only-spaces.cc Loading commit data...
read-only-spaces.h Loading commit data...
remembered-set-inl.h Loading commit data...
remembered-set.h Loading commit data...
safepoint.cc Loading commit data...
safepoint.h Loading commit data...
scavenge-job.cc Loading commit data...
scavenge-job.h Loading commit data...
scavenger-inl.h Loading commit data...
scavenger.cc Loading commit data...
scavenger.h Loading commit data...
setup-heap-internal.cc Loading commit data...
slot-set.cc Loading commit data...
slot-set.h Loading commit data...
spaces-inl.h Loading commit data...
spaces.cc Loading commit data...
spaces.h Loading commit data...
stress-marking-observer.cc Loading commit data...
stress-marking-observer.h Loading commit data...
stress-scavenge-observer.cc Loading commit data...
stress-scavenge-observer.h Loading commit data...
sweeper.cc Loading commit data...
sweeper.h Loading commit data...
worklist.h Loading commit data...