• Toon Verwaest's avatar
    [scanner] Go back to untemplatized scanning with buffering · fcfd995a
    Toon Verwaest authored
    This reverts the following 3 CLs:
    
    Revert "[scanner] Templatize scan functions by encoding"
    Revert "[asm] Remove invalid static cast of character stream"
    Revert "[scanner] Prepare CharacterStreams for specializing scanner and parser by character type"
    
    The original idea behind this work was to avoid copying, converting and
    buffering characters to be scanned by specializing the scanner functions. The
    additional benefit was for scanner functions to have a bigger window over the
    input. Even though we can get a pretty nice speedup from having a larger
    window, in practice this rarely helps. The cost is a larger binary.
    
    Since we can't eagerly convert utf8 to utf16 due to memory overhead, we'd also
    need to have a specialized version of the scanner just for utf8. That's pretty
    complex, and likely won't be better than simply bulk converting and buffering
    utf8 as utf16.
    
    Change-Id: Ic3564683932a0097e3f9f51cd88f62c6ac879dcb
    Reviewed-on: https://chromium-review.googlesource.com/1183190Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#55258}
    fcfd995a
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...