• jameslahm's avatar
    Reland "[interpreter] Optimize strict equal boolean" · fce1047f
    jameslahm authored
    This is a reland of commit 62632c08.
    Reason for previous revert: Performance regressions crbug.com/1315724.
    The reland only optimizes strict equal boolean literal like "a===true"
    or "a===false", and we generate TestReferenceEqual rather than
    TestStrictEqual for the comparasion. And also add typed optimization
    for ReferenceEqual when all inputs are boolean with boolean constant.
    
    Original change's description:
    > [interpreter] Optimize strict equal boolean
    >
    > For strict equal boolean literal like "a===true"
    > or "a===false", we could generate TestReferenceEqual
    > rather than TestStrictEqual. And in `execution_result()->IsTest()`
    > case, we could directly emit JumpIfTrue/JumpIfFalse.
    >
    > E.g.
    > ```
    > a === true
    > ```
    > Generated Bytecode From:
    > ```
    > LdaGlobal
    > Star1
    > LdaTrue
    > TestEqualStrict
    > ```
    > To:
    > ```
    > LdaGlobal
    > Star1
    > LdaTrue
    > TestReferenceEqual
    > ```
    >
    > E.g.
    > ```
    > if (a === true)
    > ```
    > Generated Bytecode From:
    > ```
    > LdaGlobal
    > Star1
    > LdaTrue
    > TestEqualStrict
    > JumpIfFalse
    > ```
    > To
    > ```
    > LdaGlobal
    > JumpIfTrue
    > Jump
    > ```
    >
    >
    > Bug: v8:6403
    > Change-Id: Ieaca147acd2d523ac0d2466e7861afb2d29a1310
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3568923
    > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    > Commit-Queue: 王澳 <wangao.james@bytedance.com>
    > Cr-Commit-Position: refs/heads/main@{#79935}
    
    Bug: v8:6403
    Change-Id: I2ae3ab57dce85313af200fa522e3632af5c3a554
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3592039Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Commit-Queue: Jakob Linke <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80141}
    fce1047f
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...