• Daniel Bevenius's avatar
    [tools] Add error handling to no_arg_cmd · fcac59ad
    Daniel Bevenius authored
    Currently, it can be little difficult to understand why a command in
    lldb-commands.py stops working. For example, at the moment running the
    jlh command results in an empty line:
    
    $ lldb --one-line "command script import ../../tools/lldb_commands.py" \
         v8_hello_world
    (lldb) br s -f hello-world.cc -l 49
    (lldb) jlh script
    
    (lldb)
    
    With this commit this would instead display the following error message:
    
    (lldb) jlh script
    Failed to evaluate command
    _v8_internal_Print_Object(*(v8::internal::Object**)(*(void*)(script))) :
    error: cannot cast from type 'v8::Local<v8::Script>' to pointer type
    'void *'
    
    The output is really only two lines but I've wrapped the lines here so
    they don't exceed the 72 column width. I'll follow up with a commit to
    fix the issue reported.
    
    Change-Id: I634a412b616dad7cadd74dce36418d27c1997777
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2083477Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68093}
    fcac59ad
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...