• jgruber's avatar
    Reland "[builtins] Remove Builtins::Name() accessors" · fcaa2c2e
    jgruber authored
    This is a reland of 2f79e035
    Original change's description:
    > [builtins] Remove Builtins::Name() accessors
    > 
    > Instead of auto-generating the Name() convenience accessor, use a macro to
    > avoid wasting code space.
    > 
    >   BUILTIN_CODE(isolate, Name)
    > 
    > expands to
    > 
    >   isolate->builtins()->builtin_handle(Builtins::kName);
    > 
    > This reduces the size of libv8.so by 134,752 bytes on a x64 release build.
    > 
    > Bug: v8:6624
    > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
    > Change-Id: Idff7ee5c45e344e73412c0f47e92553c7c7ff75f
    > Reviewed-on: https://chromium-review.googlesource.com/593607
    > Reviewed-by: Andreas Haas <ahaas@chromium.org>
    > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#47010}
    
    TBR=bmeurer@chromium.org,ahaas@chromium.org
    
    Bug: v8:6624
    Change-Id: I4733731e56dc8873ee06c2b36cac1918c0a658b2
    Reviewed-on: https://chromium-review.googlesource.com/594087
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47037}
    fcaa2c2e
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...