• Ulan Degenbaev's avatar
    [heap] Fix regressions in the configuration without concurrent marking · fbd3834e
    Ulan Degenbaev authored
    Building and running tests with v8_enabled_concurrent_marking=false
    currently produces two failures:
    1) Segmentation fault on attempt to mark a read-only object.
       This is fixed by changing MarkBit::Set to be a no-op if the object
       is already marked (which is the case for the readonly space).
    2) Missing write-barrier due to bogus condition in the bailout.
       The barrier can be skipped only if the host object is not marked yet.
    
    This also disables two concurrent allocation tests that rely on
    concurrent marking write-barrier.
    
    Bug: v8:10875
    
    Change-Id: Ib3a238fc34c8f20c697470e0bd4ac427fb4bdc0e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2421816Reviewed-by: 's avatarDominik Inführ <dinfuehr@chromium.org>
    Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70041}
    fbd3834e
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...