• Thibaud Michaud's avatar
    [wasm][x64] Fix unordered floating-point select · fb51aa40
    Thibaud Michaud authored
    Unordered floating-point (non-)equality is implemented using two flags
    on x64: kUnorderedNotEqual as "not_equal OR parity_even" and
    kUnorderedEqual as "equal AND parity_odd". Only the first flag was
    checked.
    
    This change fixes the kUnorderedNotEqual case by emitting a second
    cmov to also move the "true" value if the parity_even flag is set. The
    kUnorderedEqual case is covered by inverting the condition in the
    instruction selector.
    
    This should also be optimal according to the code emitted by clang -O3
    for equivalent C++ code.
    
    Drive-by: remove unused overload of EmitWithContinuation.
    
    R=neis@chromium.org
    CC=ahaas@chromium.org
    
    Bug: chromium:1200184
    Change-Id: Iae438d29fb5897ca910a154f140a5a6a904490ec
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2844651
    Commit-Queue: Thibaud Michaud <thibaudm@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74122}
    fb51aa40
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...