• Seth Brenith's avatar
    [torque] Allow single-param annotations in AnnotationSet · fb453dd4
    Seth Brenith authored
    Extend the order-independent annotation parsing logic to include the
    following forms:
      @foo                // bare annotation (already supported)
      @foo(0x70)          // decimal literal
      @foo(HI)            // identifier
      @foo("hello there") // quoted string
    This is obviously still pretty far from annotations in other languages,
    which usually support arbitrary expressions and multiple parameters, but
    I think it's sufficient to cover a pretty good variety of usages. The
    existing class-field annotations @if and @ifnot are reimplemented in the
    new style, meaning they could now appear in any order relative to other
    annotations on the same field (and can be repeated, though I doubt it
    would be of much use to anybody).
    
    Change-Id: I97b7c0c9a541ca3126b5ae3a2484688b04dda9f4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1754947
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63285}
    fb453dd4
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...