• Clemens Hammacher's avatar
    [wasm] Avoid transition from unhandlified to handlified · fb226a11
    Clemens Hammacher authored
    The ImportedFunctionEntry and IndirectFunctionTableEntry stored handles
    internally, but were created from raw pointers. This is not allowed.
    The two options to fix this are to either handlify the whole interface,
    or do the opposite and use raw pointers everywhere. Since no current
    user depends on a handlified interface, and both objects are being used
    in performance critical code, this CL unhandlifies the interface and
    adds a DisallowHeapAllocation scope to enforce that no GC happens while
    any ImportedFunctionEntry or IndirectFunctionTableEntry is alive.
    
    R=mstarzinger@chromium.org
    CC=titzer@chromium.org
    
    Change-Id: I098c2abcdd28c4b117272ac3ea0358ff2e56b36c
    Reviewed-on: https://chromium-review.googlesource.com/1005075
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#52531}
    fb226a11
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...