• Maciej Goszczycki's avatar
    Revert "[heap] Set read-only space's and its pages' heap_ to null." · fa4b433f
    Maciej Goszczycki authored
    This reverts commit 964edc25.
    
    Reason for revert: chromium:959190
    
    Original change's description:
    > [heap] Set read-only space's and its pages' heap_ to null.
    >
    > Various small changes are required to enable this.
    >
    > HeapObject::GetReadOnlyRoots no longer uses the Space's heap when
    > possible (see comment in ReadOnlyHeap::GetReadOnlyRoots definition).
    > This requires that ReadOnlyRoots be construct-able using a raw pointer
    > to the read-only space's roots array.
    >
    > Global read-only heap state is now cleared by tests where appropriate
    > and extra DCHECKs in ReadOnlyHeap::SetUp should make catching future
    > issues easier.
    >
    > String padding is now always cleared just before read-only space is
    > sealed when not deserializing.
    >
    > Change-Id: I7d1db1c11567be5df06ff7066f3a699125f8b372
    > Bug: v8:7464
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1535830
    > Commit-Queue: Maciej Goszczycki <goszczycki@google.com>
    > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    > Reviewed-by: Dan Elphick <delphick@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#61188}
    
    TBR=ulan@chromium.org,hpayer@chromium.org,delphick@chromium.org,goszczycki@google.com
    
    Change-Id: I53cecf3976dfeabae309040313351385f651f010
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:7464, chromium:959190
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1591608Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
    Commit-Queue: Adam Klein <adamk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#61217}
    fa4b433f
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
assembler Loading commit data...
base Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
heap Loading commit data...
interpreter Loading commit data...
libplatform Loading commit data...
parser Loading commit data...
regress Loading commit data...
torque Loading commit data...
wasm Loading commit data...
zone Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
allocation-unittest.cc Loading commit data...
background-compile-task-unittest.cc Loading commit data...
bigint-unittest.cc Loading commit data...
cancelable-tasks-unittest.cc Loading commit data...
char-predicates-unittest.cc Loading commit data...
code-stub-assembler-unittest.cc Loading commit data...
code-stub-assembler-unittest.h Loading commit data...
conversions-unittest.cc Loading commit data...
counters-unittest.cc Loading commit data...
detachable-vector-unittest.cc Loading commit data...
eh-frame-iterator-unittest.cc Loading commit data...
eh-frame-writer-unittest.cc Loading commit data...
locked-queue-unittest.cc Loading commit data...
microtask-queue-unittest.cc Loading commit data...
object-unittest.cc Loading commit data...
register-configuration-unittest.cc Loading commit data...
run-all-unittests.cc Loading commit data...
source-position-table-unittest.cc Loading commit data...
strings-storage-unittest.cc Loading commit data...
test-helpers.cc Loading commit data...
test-helpers.h Loading commit data...
test-utils.cc Loading commit data...
test-utils.h Loading commit data...
testcfg.py Loading commit data...
unicode-unittest.cc Loading commit data...
unittests.status Loading commit data...
utils-unittest.cc Loading commit data...
value-serializer-unittest.cc Loading commit data...