• Clemens Hammacher's avatar
    [test] Fix CHECK_DOUBLE_EQ and CHECK_FLOAT_EQ · fa0e55e2
    Clemens Hammacher authored
    Both macros currently call a function with individual CHECKs, which
    makes error messages only show that one part of the equality check (and
    not the the actual float values), and hides the actual location of the
    check.
    This CL refactors this such that the actual value is shown (just as
    with other CHECK_EQ macros) and it shows the right file name and line
    number.
    
    R=ahaas@chromium.org
    
    Bug: v8:7570
    Change-Id: I198e73c053178a09f14330a18069463760693f81
    Reviewed-on: https://chromium-review.googlesource.com/1027879Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#52832}
    fa0e55e2
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...