• Michael Achenbach's avatar
    Revert "[wasm] Add PKU alloc/free and support counter" · f98f496f
    Michael Achenbach authored
    This reverts commit a4c37558.
    
    Reason for revert: Speculative revert.
    Seems to break all gpu builders, e.g.:
    https://ci.chromium.org/p/v8/builders/ci/Linux%20V8%20FYI%20Release%20(NVIDIA)/14577
    
    See shards for detailed output, e.g.:
    https://chromium-swarm.appspot.com/task?id=534a8fbeaca4df10
    
    Check failed: valid_arguments. V8.WasmMemoryProtectionKeysSupport
    
    Original change's description:
    > [wasm] Add PKU alloc/free and support counter
    >
    > To enforce W^X for the WebAssembly code space, we want to explore using
    > Intel memory protection keys for userspace, also known as MPK, PKEYs, or
    > PKU. Instead of flipping page protection flags with mprotect (which
    > incurs a high syscall overhead; and which switches flags for the whole
    > process), this associates a key with each page once, and then changes
    > the permissions of that key with a fast thread-local register write.
    > That is, this gives both finger-grained permissions (per-thread) and
    > more performance.
    >
    > This CL is starts experimenting with PKUs by
    > (1) trying to allocate a protection key once per {WasmEngine} in x64
    > Linux systems, and
    > (2) adding a counter for recording the sucess/failure of that, to assess
    > the support for PKUs on the target machine.
    >
    > The low-level PKU allocating functions should be moved into base/platform
    > long-term, but are inside wasm/ for this CL.
    >
    > R=​clemensb@chromium.org
    > CC=​​jkummerow@chromium.org
    >
    > Bug: v8:11714
    > Change-Id: Ia4858970ced4d0b84cc8c2651e86dceb532c88a7
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2850932
    > Commit-Queue: Daniel Lehmann <dlehmann@google.com>
    > Reviewed-by: Clemens Backes <clemensb@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#74319}
    
    Bug: v8:11714
    Change-Id: I70349d413ac9092e2f033d138887678bfecaae17
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2868607
    Auto-Submit: Michael Achenbach <machenbach@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#74339}
    f98f496f
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...