• Jakob Gruber's avatar
    [regexp] Ensure ToString(replaceValue) is called once in @@replace · f8d11696
    Jakob Gruber authored
    @@replace should only call ToString(replaceValue) once. Prior to this
    CL this was not the case when
    
    1. the given regexp is fast
    2. the replacement is not callable
    3. and its string representation contains a '$'.
    
    In such a situation we'd call ToString both in the RegExpReplace
    builtin, and after bailing out again in the RegExpReplaceRT runtime
    function.
    
    The fix is to pass the result of ToString(replaceValue) to the runtime
    function. ToString in RegExpReplaceRT will be a no-op since the value
    is already guaranteed to be a string.
    
    Bug: chromium:947822
    Change-Id: I14b4932a5ee29e49de4c2131dc2e98b50d93da49
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559739
    Auto-Submit: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarPeter Marshall <petermarshall@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60733}
    f8d11696
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...