• jgruber's avatar
    [snapshot] Flush icache and allocate with code alignment · f8947063
    jgruber authored
    This fixes two issues related to Code object allocation: Code objects
    need to be aligned to kCodeAlignment (= 32), and the instruction cache
    needs to be flushed after deserialization.
    
    Both bugs combined manifested as a crash at a basically arbitrary point
    in the code after the Runtime::kDeserializeLazy call:
    
    0x286bc8dc:  blx     r12     // Call to Runtime::kDeserializeLazy,
                                 // generated through
                                 // GenerateTailCallToReturnedCode.
    0x286bc8e0:  mov     r2, r0  // This seemingly innocent register move
                                 // crashes hard.
    
    Bug: v8:6624,v8:6796
    Change-Id: I88c7eaf57ac851745fb7e800c92b0f5978b33466
    Reviewed-on: https://chromium-review.googlesource.com/660119Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47947}
    f8947063
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...