• Andreas Haas's avatar
    [wasm][bigint] Allow only bigints as i64-global imports · f87505ca
    Andreas Haas authored
    The fuzzer found a crash when we want to execute the {valueOf} function
    of an imported value for an i64-global. The problem is that we cannot
    execute JavaScript at that moment (I did not check why, I guess we open
    some scope at some point). I checked the WebAssembly spec now, and it
    defines that only numbers are valid values for imported globals. I
    adjust our bigint implementation accordingly with this CL, i.e. that
    only bigint values are valid as imported i64-globalsl.
    I also created github issues to discuss this problem.
    
    R=jkummerow@chromium.org
    
    Bug: chromium:1001804
    Change-Id: I47f0b31fab53163346f341ad290fd3c58e7707bf
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1792167
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63621}
    f87505ca
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...