• Eric Holk's avatar
    Revert "Reland "[wasm] always allocate memory when guard regions are needed"" · 841ca52c
    Eric Holk authored
    This reverts commit 5e76ff5a.
    
    Reason for revert: tsan failures - https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/17574
    
    Original change's description:
    > Reland "[wasm] always allocate memory when guard regions are needed"
    > 
    > This reverts commit 7cf29d8d.
    > 
    > Original change's description:
    > > [wasm] always allocate memory when guard regions are needed
    > >
    > > When using trap handlers, memory references do not get any checks inserted. This
    > > means there is no check for a null memory as happens when the memory size is
    > > 0. Normally this would be correctly caught as an out of bounds access, since the
    > > low memory addresses are not normally mapped. However, if they were mapped for
    > > some reason, we would not catch the out of bounds access.
    > >
    > > The fix is to ensure WebAssembly instances always have a guard region even if
    > > the memory is size 0.
    > >
    > > Bug: chromium:769637
    > 
    > Change-Id: I09fdaea92b7ccb3a6cc9e28392171ec098538a00
    > Reviewed-on: https://chromium-review.googlesource.com/695812
    > Commit-Queue: Eric Holk <eholk@chromium.org>
    > Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
    > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#48293}
    
    TBR=gdeepti@chromium.org,mtrofin@chromium.org,mlippautz@chromium.org,eholk@chromium.org,eholk@google.com,clemensh@chromium.org
    
    Change-Id: I52d5354126158a92602b08c48703d562ac95075b
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/699599Reviewed-by: 's avatarEric Holk <eholk@chromium.org>
    Commit-Queue: Eric Holk <eholk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48294}
    841ca52c
Name
Last commit
Last update
..
loop-stack-check.js Loading commit data...
regress-5860.js Loading commit data...
regress-709684.js Loading commit data...
regress-712569.js Loading commit data...
regress-752423.js Loading commit data...
regression-02256.js Loading commit data...
regression-02256b.js Loading commit data...
regression-02862.js Loading commit data...
regression-5531.js Loading commit data...
regression-5800.js Loading commit data...
regression-5884.js Loading commit data...
regression-6054.js Loading commit data...
regression-6164.js Loading commit data...
regression-643595.js Loading commit data...
regression-644682.js Loading commit data...
regression-647649.js Loading commit data...
regression-648079.js Loading commit data...
regression-651961.js Loading commit data...
regression-654377.js Loading commit data...
regression-663994.js Loading commit data...
regression-666741.js Loading commit data...
regression-667745.js Loading commit data...
regression-670683.js Loading commit data...
regression-674447.js Loading commit data...
regression-680938.js Loading commit data...
regression-684858.js Loading commit data...
regression-688876.js Loading commit data...
regression-689450.js Loading commit data...
regression-694433.js Loading commit data...
regression-698587.js Loading commit data...
regression-699485.js Loading commit data...
regression-702460.js Loading commit data...
regression-702839.js Loading commit data...
regression-703568.js Loading commit data...
regression-708714.js Loading commit data...
regression-710844.js Loading commit data...
regression-711203.js Loading commit data...
regression-715216-a.js Loading commit data...
regression-715216-b.js Loading commit data...
regression-717056.js Loading commit data...
regression-717194.js Loading commit data...
regression-719175.js Loading commit data...
regression-722445.js Loading commit data...
regression-724846.js Loading commit data...
regression-724851.js Loading commit data...
regression-724972.js Loading commit data...
regression-727219.js Loading commit data...
regression-727222.js Loading commit data...
regression-727560.js Loading commit data...
regression-729991.js Loading commit data...
regression-731351.js Loading commit data...
regression-734108.js Loading commit data...
regression-734246.js Loading commit data...
regression-734345.js Loading commit data...
regression-736584.js Loading commit data...
regression-737069.js Loading commit data...
regression-739768.js Loading commit data...
regression-753496.js Loading commit data...
regression-757217.js Loading commit data...
regression-763439.js Loading commit data...
regression-763697.js Loading commit data...
regression-769846.js Loading commit data...